Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing log datas in some controllers and classes #18519

Merged
merged 10 commits into from May 20, 2020
Merged

Missing log datas in some controllers and classes #18519

merged 10 commits into from May 20, 2020

Conversation

PululuK
Copy link
Member

@PululuK PululuK commented Apr 8, 2020 •
edited

Questions Answers
Branch? develop
Description? Missing log datas in some controllers and classes. When writing the logs, the object_type and object_id fields must be filled in (if necessary ...)
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #18517
How to test? See #18517

This change is Reviewable

@PululuK PululuK requested a review from a team as a code owner April 8, 2020 09:56
@prestonBot prestonBot added develop Branch Bug Type: Bug labels Apr 8, 2020
@PululuK
Copy link
Member Author

PululuK commented Apr 8, 2020

Needed for #16425

@PululuK PululuK changed the title Missing log datas in same controllers and classes Missing log datas in some controllers and classes Apr 8, 2020
Progi1984
Progi1984 previously approved these changes Apr 8, 2020
View reviewed changes
@PululuK PululuK mentioned this pull request Apr 9, 2020
Closed
@PierreRambaud
Copy link
Contributor

Could you rebase your pull request please, we update our cs-fixer configuration :)

@PululuK
Copy link
Member Author

PululuK commented Apr 14, 2020

Could you rebase your pull request please, we update our cs-fixer configuration :)

It's not the right branch ?

@PierreRambaud
Copy link
Contributor

Could you rebase your pull request please, we update our cs-fixer configuration :)

It's not the right branch ?

Yes it is, but we update our cs fixer configuration and tests where not ran with the latest changes.

@PululuK
Copy link
Member Author

PululuK commented Apr 14, 2020 •
edited

Yes it is, but we update our cs fixer configuration and tests where not ran with the latest changes.

Why rebase then? A simple git pull from remote branch should be enough, right?
If you can help me do it please ... I'm getting old for this stuff!

@PululuK
Copy link
Member Author

PululuK commented May 18, 2020

@Progi1984 @PierreRambaud

@PierreRambaud
Copy link
Contributor

Instead of using a merge commit, rebasing re-writes the project history by creating brand new commits for each commit in the original branch. It prevents having merge commits in the history.

@PululuK
Copy link
Member Author

PululuK commented May 18, 2020

Instead of using a merge commit, rebasing re-writes the project history by creating brand new commits for each commit in the original branch. It prevents having merge commits in the history.

Can you rebase please ?

@PierreRambaud
Copy link
Contributor

@PululuK Of course, I'll do it for you ❤️

@Progi1984
Copy link
Contributor

Progi1984 commented May 18, 2020 •
edited

@PierreRambaud
https://i.giphy.com/media/MDJ9IbxxvDUQM/source.gif

@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label May 18, 2020
@SD1982 SD1982 self-assigned this May 20, 2020
@SD1982
Copy link
Contributor

SD1982 commented May 20, 2020

The object type and the object ID are correctly added in the logs
capture d'écran_19

Thanks @PululuK !

@SD1982 SD1982 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels May 20, 2020
@Progi1984 Progi1984 merged commit a43e364 into PrestaShop:develop May 20, 2020
@Progi1984
Copy link
Contributor

Thanks @PululuK

@Progi1984 Progi1984 added this to the 1.7.8.0 milestone May 20, 2020
@PululuK PululuK deleted the patch-2 branch May 20, 2020 09:39
@PululuK PululuK mentioned this pull request May 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

Assignees

@SD1982 SD1982

Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Missing log datas in some controllers and classes
5 participants
@PululuK @PierreRambaud @Progi1984 @SD1982 @prestonBot