Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivation of non-native modules #25649

Closed
Tracked by #25647
marionf opened this issue Aug 19, 2021 · 2 comments · Fixed by PrestaShop/autoupgrade#498
Closed
Tracked by #25647

Deactivation of non-native modules #25649

marionf opened this issue Aug 19, 2021 · 2 comments · Fixed by PrestaShop/autoupgrade#498
Assignees
Labels
Autoupgrade Module: autoupgrade BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Major Severity: major bug > https://build.prestashop.com/news/severity-classification Module Module Must-have Kanban prioritization: issue must be included in next version

Comments

@marionf
Copy link
Contributor

marionf commented Aug 19, 2021

Describe the bug

The feature to Disable non-native modules in the auto-upgrade module is not working.
⚠️ The feature to disable non native-in modules in the Advanced parameters > Performance page is also not working and should be fixed before.

According to @Progi1984 it's because it's looking for information in the install folder which must be renamed or deleted after installing PS.
@eternoendless said that we should rather use the composer.json to disable all non native-in modules

Expected behavior

As a user making an upgrade, I want to be able to disable my non native-in modules before the upgrade to ensure its success.

When the option is enabled, we should identify native modules in the destination version, then disable all modules in the current version that aren't found on that list to prevent them to crash the upgrade or the store once the upgrade has been done.

Mockups: https://www.figma.com/file/GpRsUUCHcdhJPAaz7Eqzes/Autoupgrade?node-id=497%3A11710

Steps to Reproduce

Steps to reproduce the behavior:

  1. Install & configure the auto-upgrade module
  2. Put "Disable non-native modules" on "Yes"
  3. Go in Modules > Modules manager
  4. See that non-native modules are not disabled
  5. Lunch the upgrade
  6. Go in Modules > Modules manager in your upgraded store
  7. See that non-native modules are not disabled
@marionf marionf added Autoupgrade Module: autoupgrade Bug Type: Bug Major Severity: major bug > https://build.prestashop.com/news/severity-classification Ready Status: Issue is ready to be worked on BO Category: Back Office labels Aug 19, 2021
@marionf marionf mentioned this issue Aug 19, 2021
22 tasks
@eternoendless
Copy link
Member

To go a little further on what @marionf said, ideally we should identify native modules in the destination version, then disable all modules in the current version that aren't found on that list.

@marionf marionf changed the title Deactivation of non built-in modules Deactivation of non-native modules Aug 20, 2021
@marionf marionf added the Must-have Kanban prioritization: issue must be included in next version label Aug 25, 2021
@marionf marionf added this to Not ready in PrestaShop 8.0.0 via automation Sep 15, 2021
@marionf marionf moved this from Not ready to Ready in PrestaShop 8.0.0 Oct 13, 2021
@MatShir MatShir added the Module Module label Dec 28, 2021
@matthieu-rolland matthieu-rolland moved this from Ready to In progress in PrestaShop 8.0.0 Jan 7, 2022
@prestashop-issue-bot prestashop-issue-bot bot added WIP Status: Work In Progress and removed Ready Status: Issue is ready to be worked on labels Jan 7, 2022
@matthieu-rolland matthieu-rolland self-assigned this Jan 13, 2022
@Progi1984 Progi1984 moved this from In progress to Blocked in PrestaShop 8.0.0 Jan 13, 2022
@prestashop-issue-bot prestashop-issue-bot bot added Blocked Status: The issue is blocked by another task and removed WIP Status: Work In Progress labels Jan 13, 2022
@matthieu-rolland matthieu-rolland moved this from Blocked to Ready in PrestaShop 8.0.0 Mar 8, 2022
@matthieu-rolland matthieu-rolland moved this from Ready to Blocked in PrestaShop 8.0.0 Mar 8, 2022
@matthieu-rolland matthieu-rolland added NMI Status: issue needs more information Waiting for author Status: action required, waiting for author feedback and removed Waiting for author Status: action required, waiting for author feedback NMI Status: issue needs more information labels Mar 8, 2022
@prestashop-issue-bot prestashop-issue-bot bot added Ready Status: Issue is ready to be worked on and removed Blocked Status: The issue is blocked by another task labels Mar 8, 2022
@matthieu-rolland matthieu-rolland moved this from Blocked to Ready in PrestaShop 8.0.0 Mar 9, 2022
@matthieu-rolland matthieu-rolland moved this from Ready to Blocked in PrestaShop 8.0.0 Mar 9, 2022
@prestashop-issue-bot prestashop-issue-bot bot added the Ready Status: Issue is ready to be worked on label Mar 9, 2022
@matthieu-rolland matthieu-rolland moved this from Ready to Blocked in PrestaShop 8.0.0 Mar 9, 2022
@prestashop-issue-bot prestashop-issue-bot bot added Blocked Status: The issue is blocked by another task and removed Ready Status: Issue is ready to be worked on labels Mar 9, 2022
@Progi1984 Progi1984 moved this from Blocked to In progress in PrestaShop 8.0.0 May 24, 2022
@prestashop-issue-bot prestashop-issue-bot bot added WIP Status: Work In Progress and removed Blocked Status: The issue is blocked by another task labels May 24, 2022
@Progi1984 Progi1984 moved this from In progress to Ready in PrestaShop 8.0.0 May 24, 2022
@prestashop-issue-bot prestashop-issue-bot bot added Ready Status: Issue is ready to be worked on and removed WIP Status: Work In Progress labels May 24, 2022
@Progi1984
Copy link
Contributor

@matthieu-rolland You are now unlocked 🔓

@matthieu-rolland matthieu-rolland moved this from Ready to In progress in PrestaShop 8.0.0 May 30, 2022
@prestashop-issue-bot prestashop-issue-bot bot added WIP Status: Work In Progress and removed Ready Status: Issue is ready to be worked on labels May 30, 2022
@matks matks moved this from In progress to To be tested in PrestaShop 8.0.0 Aug 19, 2022
@prestashop-issue-bot prestashop-issue-bot bot removed the WIP Status: Work In Progress label Aug 19, 2022
@MatShir MatShir moved this from To be tested to To be reviewed in PrestaShop 8.0.0 Aug 29, 2022
@MatShir MatShir moved this from To be reviewed to In progress in PrestaShop 8.0.0 Aug 29, 2022
@prestashop-issue-bot prestashop-issue-bot bot added WIP Status: Work In Progress and removed WIP Status: Work In Progress labels Aug 29, 2022
@MatShir MatShir moved this from In progress to To be tested in PrestaShop 8.0.0 Sep 1, 2022
@prestashop-issue-bot prestashop-issue-bot bot added the WIP Status: Work In Progress label Sep 1, 2022
PrestaShop 8.0.0 automation moved this from To be tested to Done Sep 5, 2022
@prestashop-issue-bot prestashop-issue-bot bot added Fixed Resolution: issue closed because fixed and removed WIP Status: Work In Progress labels Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Autoupgrade Module: autoupgrade BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Major Severity: major bug > https://build.prestashop.com/news/severity-classification Module Module Must-have Kanban prioritization: issue must be included in next version
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants