Upgrade PS_1.7.8.8 to PS_8.0.2 fails with 1-Click Upgrade modul

[madibashop]

Prerequisites

• I understand and accept the project's code of conduct.
• I have already searched in existing issues and found no previous report of this bug.

Describe the bug and add attachments

I tried to upgrade PS v1.7.8.8 to v8.0.1
PHP: 7.4.3.3

Database: 5.7.38

Tema CLASSIC v.1.0.0

I started upgrade with cache, overrides and not native modules deactivated:

And after upgrade 8 ERRORS:

I do not know what it is causing the error. I tried 3 times.

Some ideas:
Can it be related to the contents of the database?
Can the "null" content in some field affect?
What are the conditions that the database must fulfil?

Thanks for your help

Expected behavior

I expected success upgrade.

Steps to reproduce

1. Backup copy.
2. Deactive cache, not native modules and overrides.
3. Shop offline.
4. Run 1-Click Upgrade
5. BAD RESULT: 8 errors.

PrestaShop version(s) where the bug happened

1.7.8.8

PHP version(s) where the bug happened

7.4.33

If your bug is related to a module, specify its name and its version

1-Click Upgrade v.4.15.0

[paulnoelcholot]

Hello @madibashop,

I followed the step to reproduce but I couldn't reproduce the bug. Do you have any additional information to share with us?

Thanks!

[madibashop]

I have no more information:
1 Cache offline
2 Override disabled
3 Non native modules disabled

Because this, I think if the database can influence: Fields with some null content, ... ???

[hibatallahAouadni]

Hello @madibashop

It seems your issue is related to one of your non-native modules, cause I tried on my side with three modules non-native and it works without any errors, check the screen record below:

upgrade1788-801.webm

BTW, your issue is related to this one #25649 which has been fixed with the 1-ClickUpgrade module v4.15.0
Waiting for your feedback.

Thanks!

[VIPWebdesign]

Hi

I have the same problem with the 5 prestashop sites. I upgrade to the latest 1.7.8.8 version clean chach etc and then i selected major release. I upgrade with 1 click upgrade latest version and the website is crash with error 429 Too Many Requests
nginx the update kills and the website is broken.
I tryed to install the files with ftp but the omly solutions is restore.

Have anybody an idea?

Regards

Eric

[madibashop]

I tried again to update.
Aside from doing all the above, I manually disabled ALL non-native modules and override.
The update ends with exactly the same errors. Updates the database correctly and fails below without finishing the process.

After that Prestashop works, but has a major problem. Non-native modules can be activated, they seem to be activated, but they don't work. They do nothing, as if they did not exist.

Uninstalling a module, deleting configuration, and reinstalling it does not solve the problem.
Again: backtrack from backup.

Configuration information is:

[AureRita]

Hi @madibashop ,

Thank you for your report and you details. I reproduce the issue with PrestaShop version 1.7.8.8 as you can see

Untitled_.Mar.13.2023.3_39.PM.webm

Nice catch ! It's a regression ! I'll add it to the patch backlog.

Please be aware that some issues might take a very long time to be resolved. If this one is important to you and you cannot wait for it to be fixed on the project’s own time, we strongly suggest you consider contacting a professional to help you.

If you fix the issue on your end, please contribute it back to the project. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thank you

[madibashop]

Someone suggested if the problem was the PS Checkout module. I have again tried to update. This time it is for version 8.0.2.The result has been exactly the same. Same errors:

Database upgrade OK

---

errores

---

[INTERNAL]
/homepages//****//************/PrestaShop/**********/src/Core/Addon/Theme/ThemeManager.php line 384 - PrestaShop\PrestaShop\Core\Domain\Theme\Exception\FailedToEnableThemeModuleException: Unfortunately, the module did not return additional details. #0

/homepages//****//************/PrestaShop/**********/src/Core/Addon/Theme/ThemeManager.php(245): PrestaShop\PrestaShop\Core\Addon\Theme\ThemeManager->doEnableModules(Array) #1

/homepages//****//************/PrestaShop/**********/modules/autoupgrade/classes/UpgradeTools/ThemeAdapter.php(113): PrestaShop\PrestaShop\Core\Addon\Theme\ThemeManager->enable('classic') #2

/homepages//****//************/PrestaShop/**********/modules/autoupgrade/classes/UpgradeTools/ThemeAdapter.php(51): PrestaShop\Module\AutoUpgrade\UpgradeTools\ThemeAdapter->enableTheme17('classic') #3

/homepages//****//************/PrestaShop/**********/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php(662): PrestaShop\Module\AutoUpgrade\UpgradeTools\ThemeAdapter->enableTheme('classic') #4

/homepages//****//************/PrestaShop/**********/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php(119): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreUpgrader->updateTheme() #5

/homepages//****//************/PrestaShop/**********/modules/autoupgrade/classes/TaskRunner/Upgrade/UpgradeDb.php(42): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreUpgrader->doUpgrade() #6

/homepages//****//*******/PrestaShop///autoupgrade/ajax-upgradetab.php(53): PrestaShop\Module\AutoUpgrade\TaskRunner\Upgrade\UpgradeDb->run() #7 {main}

I have tried to analyse the first error, but I do not understand the cause of the problem:

---

FIRST ERROR #0:

/homepages//****//************/PrestaShop/**********/src/Core/Addon/Theme/ThemeManager.php line 384

/**
 * Reset the modules received in parameters if they are installed and enabled.
 *
 * @param string[] $modules
 *
 * @return $this
 */
private function doResetModules(array $modules)
{
    $moduleManagerBuilder = ModuleManagerBuilder::getInstance();
    $moduleManager = $moduleManagerBuilder->build();

    foreach ($modules as $moduleName) {
        if ($moduleManager->isInstalled($moduleName)) {
            $moduleManager->reset($moduleName);
        }
    }

    return $this;
}

---

FailedToEnableThemeModuleException.php

namespace PrestaShop\PrestaShop\Core\Domain\Theme\Exception;

class FailedToEnableThemeModuleException extends ThemeException
{
/**
* @var string
*/
private $moduleName;

public function __construct(
    $moduleName,
    $message = '',
    $code = 0,
    $previous = null
) {
    parent::__construct($message, $code, $previous);

    $this->moduleName = $moduleName;
}

/**
 * @return string
 */
public function getModuleName()
{
    return $this->moduleName;
}

}

---

I don't know what else I can do.
Thanks!

[HanaRebaiQA]

Hello @madibashop

It seems that your issue is similar to this one #30761 Do you confirm it?

[madibashop]

Yes.

My errors are not the same, but it is similar.
I can't update.

Disabling non native modules, cache, override, ... and always same errors:

errores

[INTERNAL]
/homepages//****//************/PrestaShop/**********/src/Core/Addon/Theme/ThemeManager.php line 384 - PrestaShop\PrestaShop\Core\Domain\Theme\Exception\FailedToEnableThemeModuleException: Unfortunately, the module did not return additional details. #0

/homepages//****//************/PrestaShop/**********/src/Core/Addon/Theme/ThemeManager.php(245): PrestaShop\PrestaShop\Core\Addon\Theme\ThemeManager->doEnableModules(Array) https://github.com/PrestaShop/PrestaShop/pull/1

/homepages//****//************/PrestaShop/**********/modules/autoupgrade/classes/UpgradeTools/ThemeAdapter.php(113): PrestaShop\PrestaShop\Core\Addon\Theme\ThemeManager->enable('classic') https://github.com/PrestaShop/PrestaShop/pull/2

/homepages//****//************/PrestaShop/**********/modules/autoupgrade/classes/UpgradeTools/ThemeAdapter.php(51): PrestaShop\Module\AutoUpgrade\UpgradeTools\ThemeAdapter->enableTheme17('classic') https://github.com/PrestaShop/PrestaShop/pull/3

/homepages//****//************/PrestaShop/**********/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php(662): PrestaShop\Module\AutoUpgrade\UpgradeTools\ThemeAdapter->enableTheme('classic') https://github.com/PrestaShop/PrestaShop/pull/4

/homepages//****//************/PrestaShop/**********/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php(119): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreUpgrader->updateTheme() https://github.com/PrestaShop/PrestaShop/pull/5

/homepages//****//************/PrestaShop/**********/modules/autoupgrade/classes/TaskRunner/Upgrade/UpgradeDb.php(42): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreUpgrader->doUpgrade() https://github.com/PrestaShop/PrestaShop/pull/6

/homepages//****//*******/PrestaShop///autoupgrade/ajax-upgradetab.php(53): PrestaShop\Module\AutoUpgrade\TaskRunner\Upgrade\UpgradeDb->run() https://github.com/PrestaShop/PrestaShop/pull/7 {main}

[madibashop]

Update with som errors.
Web is running OK.