Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BO combination price editor problem - Number comma formatter #25718

Closed
skeccy opened this issue Aug 27, 2021 · 9 comments · Fixed by #25749
Closed

BO combination price editor problem - Number comma formatter #25718

skeccy opened this issue Aug 27, 2021 · 9 comments · Fixed by #25749
Assignees
Labels
1.7.7.6 Affects versions BO Category: Back Office Bug Type: Bug Combinations Product type: issue about products with combinations Fixed Resolution: issue closed because fixed Major Severity: major bug > https://build.prestashop.com/news/severity-classification Old Products Page Concerns the old product page PR available Solution: issue is being addressed Regression Type: regression Taxes and Prices Component: Which BO section is concerned
Milestone

Comments

@skeccy
Copy link

skeccy commented Aug 27, 2021

Describe the bug

20210826_131543.MP4

Hello everyone, I am writing this post to report a problem I had recently following an update of prestashop from version 1.7.7.6 to 1.7.7.7.
In the back office, if I try to edit a product that contains combinations, as soon as I enter the single combination editor, the price entry seems to go crazy. It is useless to try to cancel the price. I can only enter the price through massive actions in the combination summary. The problem seems to arise especially with already existing combinations. I am attaching a video showing the problem.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to BO > Catalog > Products > Edit a product with combinations
  2. In the Combinations Tab > Edit a combination
  3. In the field Impact on the price (tax incl.) > try to add a decimal with a comma or point for example 1.2, 1,2, 1N000
  4. See error => the price is converted

Seems related to this PR: #24339
Has anyone had the same problem as me? Is there a solution?
Prestashop 1.7.7.7
PHP 7.3

Thanks

@khouloudbelguith
Copy link
Contributor

Hi @skeccy,

Thanks for your report.
Please next time you need to follow the exact template to create a new issue.
Read more about how we expect the issues to be handled here.

  • Did you use the 1-click upgrade module? if yes, what is the exact version did you use?
  • Have you any errors during the upgrade?
  • This issue occurs only with products created before the upgrade or the same issue when you try to edit new products created after the upgrade?

Thanks!

@khouloudbelguith khouloudbelguith added 1.7.7.7 Affects versions BO Category: Back Office Bug Type: Bug Combinations Product type: issue about products with combinations NMI Status: issue needs more information Old Products Page Concerns the old product page Taxes and Prices Component: Which BO section is concerned labels Aug 27, 2021
@skeccy
Copy link
Author

skeccy commented Aug 27, 2021

@khouloudbelguith Scuse me, this is my first bug report. sorry.

One click upgrade module version is 4.12 no error reported during upgrade
The error occurs both on an existing combination created previously and with the creation of a new product with combinations. The error also occurs if I write the price with decimals, as soon as I put the comma or the point using the numeric keypad of the keyboard

@khouloudbelguith
Copy link
Contributor

@skeccy, thanks for these clarifications.

I manage to reproduce the issue with PS1776 and PS1777.
It is ok with PS1775.
I'll add this to the debug backlog so that it's fixed.

Please be aware that due to the high number of reported issues, some bugs might take a very long time to be resolved. If this issue is important to you and you cannot wait for it to be fixed on the project's own time, we strongly suggest you consider hiring a specialist to help you.

If you manage to get the problem fixed, then please contribute the fix back to the project as a Pull Request. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thanks!

@khouloudbelguith khouloudbelguith changed the title BO combination price editor problem prestashop 1.7.7.7 BO combination price editor problem - Number comma formatter Aug 27, 2021
@khouloudbelguith khouloudbelguith added 1.7.7.6 Affects versions Ready Status: Issue is ready to be worked on Regression Type: regression Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification and removed NMI Status: issue needs more information 1.7.7.7 Affects versions labels Aug 27, 2021
@khouloudbelguith khouloudbelguith added this to Not ready in PrestaShop 1.7.8.1 via automation Aug 27, 2021
@skeccy
Copy link
Author

skeccy commented Aug 27, 2021

Thanks a lot @khouloudbelguith
I'm not a programming expert, but I want to help the community develop the project so I find it very important to report any bugs.
if I find a solution I will be happy to communicate the solution. Thanks

@skeccy
Copy link
Author

skeccy commented Aug 28, 2021

@khouloudbelguith Scuse me, How can I contact you to report another problem of mine other than the one reported?

@MatShir
Copy link
Contributor

MatShir commented Aug 30, 2021

@skeccy If you find a bug, you just have to create a new one issue as you did for this one. On your issue, you have to share the steps of how did you reproduce the bug, your PrestaShop's version and PHP's version.

@MatShir MatShir removed this from Not ready in PrestaShop 1.7.8.1 Aug 30, 2021
@MatShir MatShir added this to To do in PrestaShop 1.7.7.8 Aug 30, 2021
@MatShir MatShir added Major Severity: major bug > https://build.prestashop.com/news/severity-classification and removed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification labels Aug 30, 2021
@matks matks mentioned this issue Aug 30, 2021
6 tasks
@matks matks added this to the 1.7.7.8 milestone Aug 30, 2021
@prestonBot prestonBot added the PR available Solution: issue is being addressed label Aug 31, 2021
@sowbiba sowbiba moved this from To do to In progress in PrestaShop 1.7.7.8 Aug 31, 2021
@jolelievre jolelievre moved this from In progress to To be tested in PrestaShop 1.7.7.8 Aug 31, 2021
@khouloudbelguith khouloudbelguith added Fixed Resolution: issue closed because fixed and removed Ready Status: Issue is ready to be worked on labels Sep 2, 2021
@khouloudbelguith
Copy link
Contributor

Hi,

Fixed by #25749

Thanks!

@skeccy
Copy link
Author

skeccy commented Sep 4, 2021

@khouloudbelguith
I'm sorry but I didn't understand in prestashop 1.7.7.7 which file to modify, assuming that I use the classic theme. What is the correct path where I can make the change?

@MatShir MatShir moved this from To be tested to Done in PrestaShop 1.7.7.8 Sep 6, 2021
@khouloudbelguith
Copy link
Contributor

Hi @skeccy,

The PrestaShop 1.7.7.8. is released.
As always, you can use the 1-click update to upgrade between minor versions without much trouble. In order to avoid problems, remember not to change core files, check the compatibility of your modules and theme beforehand, and test the upgrade on a separate machine from your production.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.7.6 Affects versions BO Category: Back Office Bug Type: Bug Combinations Product type: issue about products with combinations Fixed Resolution: issue closed because fixed Major Severity: major bug > https://build.prestashop.com/news/severity-classification Old Products Page Concerns the old product page PR available Solution: issue is being addressed Regression Type: regression Taxes and Prices Component: Which BO section is concerned
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants