Product combination price edit : Use blur instead of onkeyup to avoid price flip

[sowbiba]

Questions	Answers
Branch?	1.7.7.x
Description?	Use blur to wait until user ends typing before round the price
Type?	bug fix
Category?	BO
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #25718 & #25753
How to test?	See #25718 & #25753
Possible impacts?	Test with ecotax

---

This change is 

[jolelievre]

Thanks @sowbiba

Seems good to me, I would just like to have the approval from @PierreRambaud since he worked on the number formatted part

[PierreRambaud]

I approve but I don't know if this trigger is still needed:
https://github.com/PrestaShop/PrestaShop/blob/develop/admin-dev/themes/default/js/bundle/product/form.js#L1969$

[sowbiba]

I approve but I don't know if this trigger is still needed:
https://github.com/PrestaShop/PrestaShop/blob/develop/admin-dev/themes/default/js/bundle/product/form.js#L1969$

$(document).on('blur', '.combination-form .attribute_priceTI', function() { ==> TI edit

TI edit => Impact on TE
                           => get TI input value
                              compute TE value
                              update TE input
                              Impact on TI
                                  => compute TI value (depending on TE)
                                     update TI input

this is weird to me, we assume to (maybe) override the value edited

[jolelievre]

Careful, you are changing the behaviour here, as the removed updateImpactTEInput function used to update both fields tax excluded and included (and recompute tax included at the same time)

[jolelievre]

The whole behaviour is quite touchy and prone to many errors To avoid any risk I would have kept the update* methods, and you can simply remove the change trigger code I guess

Also you need to be careful because not only the combination form is updated, the combination list also needs to be updated and it's not handled in this file. The list update is handled here

PrestaShop/admin-dev/themes/default/js/bundle/product/product-combinations.js

Line 153 in 339f1c8

updateFinalPrice($(input.parents('tr')[0]));

It relies on the change event so it might break this feature, if you only wanted to remove the change trigger for "clean code" the DON'T 😅. Because this whole code is a mess and a slight change can break many unexpected things

As long as your bug is fixed you should try to minimize the modifications as much as possible. This code is bound to be removed once the product page is redone in v8 anyway, so now is not the time to do overkill changes unless you plan on releasing a 1.7.9 next week.. ^^

[jolelievre]

Thanks @sowbiba

[jolelievre]

Thank you @atomiix for fixing my mistakes ^^

[khouloudbelguith]

Hi @sowbiba, @atomiix,

I checked with @Robin-Fischer-PS
It is ok ✔️

About the rounding price, we have old issues:
#9855
#12078

But before PS1.7.7.5, we need to refresh the page to show the error and now the rounding bug is displayed when we click outside because of blur (The event is on blur. As soon as you leave the field, the calculation is done)

And about the ecotax issue, we have old issues
#9972
#24373

So it seems that the ecotax is not working since before.

Thanks!

[PierreRambaud]

Thank you @sowbiba and @atomiix