Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with dynamical form rendering in 1.7.8.1 #26786

Closed
2 tasks done
krekken opened this issue Nov 29, 2021 · 11 comments · Fixed by #26987
Closed
2 tasks done

Error with dynamical form rendering in 1.7.8.1 #26786

krekken opened this issue Nov 29, 2021 · 11 comments · Fixed by #26987
Assignees
Labels
1.7.8.0 Affects versions BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Major Severity: major bug > https://build.prestashop.com/news/severity-classification migration symfony migration project Modules Component: Which BO section is concerned PR available Solution: issue is being addressed Regression Type: regression Verified The issue has been reproduced
Milestone

Comments

@krekken
Copy link

krekken commented Nov 29, 2021

Prerequisites

Describe the bug and add screenshots

When i wan't to use a form, where my entity is dynamical from the database, with a form structure like this:

{{form_start(form)}}
{# form content #}
{{form_end(form)}}

I get this error message.
image

If i use {{form(form)}} it actually works, but thats not good for me, cause i want to customize the template.

Expected behavior

Expected behavior is to successfully display my form, instead of getting an error message

Steps to reproduce

I made an example module, which can reproduce this bug.
https://github.com/krekken/formbugreproduce

if you install it on a 1.7.7.8 prestashop it will work, but it won't work if you install it on a 1.7.8.1 container.

image
the Form Bug Reproduce tab is the one, which contains the bugged form

PrestaShop version(s) where the bug happened

1.7.8.1

PHP version(s) where the bug happened

7.4.25

If your bug is related to a module, specify its name and its version

No response

@krekken krekken added the Bug Type: Bug label Nov 29, 2021
@matks
Copy link
Contributor

matks commented Nov 29, 2021

Wah 😮 that's very weird

-form(form) works but not form_start(form)

  • fine with 1.7.7 but not 1.7.8

@hibatallahAouadni
Copy link
Contributor

Hello @krekken

Following these steps, I had no issue:

  1. Clone your module under /modules
  2. Access to BO>IMPROVE>Modules>Module Catalog
  3. Install the module
  4. Click on Configure button
  5. Save the configuration
  6. Success => no error

image

Is there a missing step to reproduce the issue?
Please check and feedback.

Thanks!

@hibatallahAouadni hibatallahAouadni added 1.7.8.1 Affects versions BO Category: Back Office Modules Component: Which BO section is concerned NMI Status: issue needs more information labels Nov 29, 2021
@krekken
Copy link
Author

krekken commented Nov 29, 2021

image
i added a tab, and if you click on that you'll be able to see the bug. its either working if you're using 1.7.7.8, or not if you're using 1.7.8.1

i edited the issue, so it says so now

@krekken
Copy link
Author

krekken commented Dec 7, 2021

@hibatallahAouadni have u managed to reproduce the bug?

@hibatallahAouadni
Copy link
Contributor

Hello @krekken

With PS1.7.8.1 and PS1.7.7.8, I have the same behavior:

  1. Clone your module under /modules
  2. Access to BO>IMPROVE>Modules>Module Catalog
  3. Install the module
  4. Click on Configure button
  5. Save the configuration
  6. Success
  7. Click on Form Bug Reproduce in Main Menu
  8. An exception was thrown

image

Please check and feedback.
Thanks!

@krekken
Copy link
Author

krekken commented Dec 7, 2021

Hello @krekken

With PS1.7.8.1 and PS1.7.7.8, I have the same behavior:

1. Clone your module under /modules

2. Access to BO>IMPROVE>Modules>Module Catalog

3. Install the module

4. Click on Configure button

5. Save the configuration

6. Success

7. Click on **Form Bug Reproduce** in Main Menu

8. An exception was thrown

image

Please check and feedback. Thanks!

that is a different error. i updated the module, so if you re-download it, and install it again, it should now handle french, and show you the actual error.

@marwachelly
Copy link

Hello @krekken ,

With PS1.7.8.1 I still have another exception:

  1. Clone your module under /modules
  2. Access to BO>IMPROVE>Modules>Module Catalog
  3. Install the module
  4. Click on Configure button
  5. Save the configuration
  6. Success
  7. Click on Form Bug Reproduce in Main Menu
  8. An exception was thrown

image

Could you please check?

Thanks,

@krekken
Copy link
Author

krekken commented Dec 8, 2021

Hello @krekken ,

With PS1.7.8.1 I still have another exception:

  1. Clone your module under /modules
  2. Access to BO>IMPROVE>Modules>Module Catalog
  3. Install the module
  4. Click on Configure button
  5. Save the configuration
  6. Success
  7. Click on Form Bug Reproduce in Main Menu
  8. An exception was thrown

image

Could you please check?

Thanks,

i replaced the language name with "placeholder" so if you download it again, and reinstall it, it should work, with every language name now

@HanaRebaiQA
Copy link

Hello @krekken

I did to download the module again and reinstall it. But i have another exception :

  1. Clone the module under /modules
  2. Go to BO>IMPROVE>Modules>Module Catalog
  3. Install the module
  4. Click on Configure button > Save
  5. Click on Form Bug Reproduce under BO > SELL

Another exception was thrown

image

Please check again and feedback!

Thanks!

@krekken
Copy link
Author

krekken commented Dec 10, 2021

Hello @krekken

I did to download the module again and reinstall it. But i have another exception :

  1. Clone the module under /modules
  2. Go to BO>IMPROVE>Modules>Module Catalog
  3. Install the module
  4. Click on Configure button > Save
  5. Click on Form Bug Reproduce under BO > SELL

Another exception was thrown

image

Please check again and feedback!

Thanks!

thats the bug. try it on 1.7.7.8, it works there, but wont work in 1.7.8

@HanaRebaiQA
Copy link

HanaRebaiQA commented Dec 13, 2021

Hello,

I did'nt manage to reporduce the issue on PS1778. So, it's a regression.
image

I'll add this to the debug backlog so that it's fixed.

Please be aware that due to the high number of reported issues, some bugs might take a very long time to be resolved.
If you manage to get the problem fixed, then please contribute the fix back to the project as a Pull Request. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thank you!

@HanaRebaiQA HanaRebaiQA added Major Severity: major bug > https://build.prestashop.com/news/severity-classification Regression Type: regression Verified The issue has been reproduced Needs Specs Status: issue needs to be specified and removed NMI Status: issue needs more information labels Dec 13, 2021
@HanaRebaiQA HanaRebaiQA added this to Regression issues 1.7.8.x in Backlog Patch via automation Dec 13, 2021
@MatShir MatShir removed this from Regression issues 1.7.8.x in Backlog Patch Dec 13, 2021
@MatShir MatShir added this to Not ready in PrestaShop 1.7.8.3 via automation Dec 13, 2021
@hibatallahAouadni hibatallahAouadni added 1.7.8.0 Affects versions and removed 1.7.8.1 Affects versions labels Dec 13, 2021
@MatShir MatShir moved this from Not ready to Ready in PrestaShop 1.7.8.3 Dec 13, 2021
@prestashop-issue-bot prestashop-issue-bot bot added the Ready Status: Issue is ready to be worked on label Dec 13, 2021
@MatShir MatShir added the migration symfony migration project label Dec 13, 2021
@hibatallahAouadni hibatallahAouadni removed the Needs Specs Status: issue needs to be specified label Dec 13, 2021
@atomiix atomiix self-assigned this Dec 14, 2021
@prestonBot prestonBot added the PR available Solution: issue is being addressed label Dec 14, 2021
@atomiix atomiix linked a pull request Dec 14, 2021 that will close this issue
@atomiix atomiix moved this from Ready to To be reviewed in PrestaShop 1.7.8.3 Dec 14, 2021
@prestashop-issue-bot prestashop-issue-bot bot added WIP Status: Work In Progress and removed Ready Status: Issue is ready to be worked on labels Dec 14, 2021
@jolelievre jolelievre moved this from To be reviewed to To be tested in PrestaShop 1.7.8.3 Dec 16, 2021
@prestashop-issue-bot prestashop-issue-bot bot removed the WIP Status: Work In Progress label Dec 16, 2021
@matks matks moved this from To be tested to Done in PrestaShop 1.7.8.3 Dec 16, 2021
@prestashop-issue-bot prestashop-issue-bot bot added the Fixed Resolution: issue closed because fixed label Dec 16, 2021
@matks matks added this to the 1.7.8.3 milestone Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.8.0 Affects versions BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Major Severity: major bug > https://build.prestashop.com/news/severity-classification migration symfony migration project Modules Component: Which BO section is concerned PR available Solution: issue is being addressed Regression Type: regression Verified The issue has been reproduced
Projects
No open projects
8 participants