Fixes form throwing exception when rendering from module #26986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -274,7 +274,7 @@ | |||
| {% endif %} | |||
| {{ extraVars.label }} | |||
|
|
|||
| {% if form.vars.label_attr and form.vars.label_attr['popover'] %} | |||
| {% if form.vars.label_attr is defined and form.vars.label_attr and form.vars.label_attr['popover'] %} | |||
| {{ include('@Common/HelpBox/helpbox.html.twig', {'content': form.vars.label_attr['popover']}) }} | |||
There was a problem hiding this comment.
Not sure if we still need and form.vars.label_attr part, I guess it's helpful to check it's not false.
jolelievre
reviewed
Dec 15, 2021
Changed is defined logic Co-authored-by: Jonathan Lelievre <jo.lelievre@gmail.com>
matks
approved these changes
Dec 15, 2021
|
Thanks @JevgenijVisockij I'm sorry I'm gonna close this PR in favor of this one #26987 I know you created yours first, but the other one already targets the right branch and fixes the 178 CI so it's more urgent ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is