Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are no Spanish translations in the ps_emailalerts module #27026

Closed
2 tasks done
Tracked by #22632
alfonsolr09 opened this issue Dec 19, 2021 · 23 comments
Closed
2 tasks done
Tracked by #22632

There are no Spanish translations in the ps_emailalerts module #27026

alfonsolr09 opened this issue Dec 19, 2021 · 23 comments
Assignees
Labels
1.7.7.3 Affects versions BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification PR available Solution: issue is being addressed ps_emailalerts Module: Mail Alerts Translations Label: Which BO under menu is concerned Verified The issue has been reproduced
Milestone

Comments

@alfonsolr09
Copy link

alfonsolr09 commented Dec 19, 2021

Prerequisites

Describe the bug and add screenshots

There are no Spanish translations in the ps_emailalerts module
image

Expected behavior

No response

Steps to reproduce

Ps_mailalerts

PrestaShop version(s) where the bug happened

1.7.7.3

PHP version(s) where the bug happened

7.3

If your bug is related to a module, specify its name and its version

ps_mailalerts

@alfonsolr09 alfonsolr09 added the Bug Type: Bug label Dec 19, 2021
@hibatallahAouadni
Copy link
Contributor

Hello @alfonsolr09

You encounter this issue cause there's missing traductions, please follow these steps:

  1. BO>IMPROVE>International>Translations
  2. In the first block Modify translations
  3. Choose Installed modules translations as Type of translation
  4. Select Mail alerts as Select your module
  5. Set Spanish as Select your language
  6. Click on Modify button
  7. Search the sentences with English traduction:
    image
  8. Change it
    image
  9. Save
  10. Check the module
    image

Closing the issue 😉
Thanks!

@hibatallahAouadni hibatallahAouadni added BO Category: Back Office Invalid Resolution: issue closed because invalid ps_emailalerts Module: Mail Alerts Translations Label: Which BO under menu is concerned labels Dec 20, 2021
@alfonsolr09
Copy link
Author

alfonsolr09 commented Dec 24, 2021

I want to add the Spanish translations but i cant find the file...
reopen this pls

@hibatallahAouadni
Copy link
Contributor

Hello @alfonsolr09

I want to add the Spanish translations but i cant find the file...

What file you want to add?? and where?
Waiting for your feedback.

Thanks!

@alfonsolr09
Copy link
Author

Spanish translations but not only for me. I want to add here on github

@rickygzz
Copy link
Contributor

@alfonsolr09 Translations are made within crowdin.com. I you want to collaborate you can ask to join anytime.

Although Spanish is fully translated, there is space for translation improvements.

image

image

However, I am not sure why ps_emailalerts is not showing the translations.

The development of ps_emailalerts may be tracked from https://github.com/PrestaShop/ps_emailalerts .

Waiting to see any update from the team

@alfonsolr09
Copy link
Author

It is true, I already checked the translations previously and as you say PrestaShop is completely translated in crowdin.

For some reason that I do not know the translations of that module are not shown...

@hibatallahAouadni
Copy link
Contributor

FYI @Julievrz

@Julievrz
Copy link
Contributor

Julievrz commented Jan 3, 2022

FYI @Julievrz

Hi there,

Sorry for the late answer, I was out of the office.

Indeed, all ps_emailalerts strings are translated and validated in Crowdin, so Spanish translations should appear in the BO. I don't know why it doesn't work. 🤔

@Julievrz Julievrz reopened this Jan 3, 2022
@hibatallahAouadni hibatallahAouadni added TBR Status: issue to be reproduced 1.7.7.3 Affects versions and removed Invalid Resolution: issue closed because invalid labels Jan 3, 2022
@hibatallahAouadni hibatallahAouadni self-assigned this Jan 3, 2022
@atomiix
Copy link
Contributor

atomiix commented Jan 3, 2022

From what I can see, translations for module ps_emailalert are not included in the language pack downloaded from i18n.prestashop.com and it seems "normal" as the module ps_emailalert is not a native module (not included in composer.json)

@hibatallahAouadni hibatallahAouadni removed their assignment Jan 3, 2022
@hibatallahAouadni hibatallahAouadni added Needs Specs Status: issue needs to be specified Waiting for wording Status: action required, waiting for wording and removed TBR Status: issue to be reproduced labels Jan 3, 2022
@MatShir
Copy link
Contributor

MatShir commented Jan 3, 2022

@atomiix will the issue be fixed after the module will be included in the zip (see issue #24643)?

@hibatallahAouadni hibatallahAouadni added the Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification label Jan 4, 2022
@atomiix
Copy link
Contributor

atomiix commented Jan 4, 2022

@alfonsolr09 @Julievrz @MatShir plot twist: translations are there but in the module ps_emailalert we use the translation domain Modules.Emailalerts.Admin but the translations are in the Modules.Mailalerts.Admin domain 😅
It seems that it was a desired change from this PR and Pablo stated that we'd have to re-extract the default catalogue

@prestonBot prestonBot added the PR available Solution: issue is being addressed label Jan 4, 2022
@hibatallahAouadni hibatallahAouadni removed the Waiting for wording Status: action required, waiting for wording label Jan 4, 2022
@hibatallahAouadni hibatallahAouadni added Ready Status: Issue is ready to be worked on Verified The issue has been reproduced and removed Needs Specs Status: issue needs to be specified labels Jan 4, 2022
@Progi1984
Copy link
Contributor

Fixed by @jolelievre in #27193

@prestashop-issue-bot prestashop-issue-bot bot removed the Ready Status: Issue is ready to be worked on label Jan 6, 2022
@Progi1984 Progi1984 added this to the 1.7.8.3 milestone Jan 6, 2022
@hibatallahAouadni hibatallahAouadni added the Fixed Resolution: issue closed because fixed label Jan 6, 2022
@marioquartz
Copy link

Im using the last version 1.7.8.5. ITS NOT FIXED. So I have a question: How I fix manually. What file I have to modify. Or how modify the domain.
Because I need spanish translations. And of course I dont gonna translate from scratch.

@prestashop-issue-bot prestashop-issue-bot bot added the Topwatchers Backlog prioritization: issue reported & followed by +6 people label Apr 1, 2022
@hibatallahAouadni hibatallahAouadni removed the Topwatchers Backlog prioritization: issue reported & followed by +6 people label Apr 1, 2022
@MatShir
Copy link
Contributor

MatShir commented Apr 7, 2022

@marioquartz have you update the module ? It is weird on my site it is working

@marioquartz
Copy link

With v2.3.3 the only way to "fix" it is download the translated mails from other version and copy it in the child theme.

@MatShir
Copy link
Contributor

MatShir commented Apr 8, 2022

Are we talking about the same thing ? Create a new issue here with screenshots and details steps, so we can try to reproduce your issue ?

@marioquartz
Copy link

The shop is in production now. So its not posible touch nothing. Maybe in the next shop I can make test.

@alfonsolr09
Copy link
Author

now works good, thanks 👍

@lmeyer1
Copy link
Contributor

lmeyer1 commented Apr 12, 2022

@marioquartz You have to update the translations
Capture d’écran 2022-04-12 120151

@marioquartz
Copy link

You have to update the translations

I updated two times, as minimun. In the end, copy the files from other version in my theme folder was the fix. I hope your open issue makes them fix it in their end.

@alfonsolr09
Copy link
Author

You have to update the translations

I updated two times, as minimun. In the end, copy the files from other version in my theme folder was the fix. I hope your open issue makes them fix it in their end.

What have you updated?

Have you tried to update ps_mailalerts module?
And the translations??

@marioquartz
Copy link

marioquartz commented Apr 13, 2022

I updated (April 1st):
-Shop
-Module
-Translations
So yes. All, the 100% of all things that can be updated is updated. And no, the translations were broken. The only fix were copy the translations of other version in the folder of my child theme of clasic theme.
I can not update now (April 13th) because I had to change some strings related with tax.

@alfonsolr09
Copy link
Author

I have updated everything, the store to the latest version 1.7.8.5 and the module also to the latest version and the translations work correctly in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.7.3 Affects versions BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification PR available Solution: issue is being addressed ps_emailalerts Module: Mail Alerts Translations Label: Which BO under menu is concerned Verified The issue has been reproduced
Projects
None yet
Development

No branches or pull requests