[BO] The ps_reminder module archived but still exists in email theme folder

[mparvazi]

Prerequisites

• I understand and accept the project's code of conduct
• I have already searched in existing issues and found no previous report of this bug.

Describe the bug and add screenshots

The ps_reminder module has been archived but its twig layouts still exists in email theme folders:

PrestaShop/mails/themes/classic/modules/ps_reminder
PrestaShop/mails/themes/modern/modules/ps_reminder

After a fresh install of PS, the ps_reminder folder will be created in modules folder by email theme generator.

Expected behavior

If this module is no longer available and cannot be used by other modules, then its items should be removed.

Folders that should be deleted:
PrestaShop/mails/themes/classic/modules/ps_reminder
PrestaShop/mails/themes/modern/modules/ps_reminder

Files that should be reviewed:
PrestaShop/.gitignore
PrestaShop/tests/Integration/Core/MailTemplate/MailTemplateGeneratorTest.php
PrestaShop/tests/Unit/Core/MailTemplate/LayoutVariablesBuilderTest.php

Translation file that should be reviewed:
PrestaShop/translations/default/EmailsBody.xlf

Translation file that should be deleted:
PrestaShop/translations/default/ModulesReminderAdmin.xlf

Steps to reproduce

1. Go to BO > Design > Email Theme
2. Select a theme for preview
3. The ps_reminder exists in grid table

PrestaShop version(s) where the bug happened

8.0

PHP version(s) where the bug happened

No response

If your bug is related to a module, specify its name and its version

ps_reminder

[HanaRebaiQA]

Hello @mparvazi

Thanks for reporting this issue.
I did manage to reproduce the issue from PS1780, PS1781, PS178x & develop.
https://watch.screencastify.com/v/V7qQxRfRvjTm2tke78LO

It's a regression, because this issue is not reproduced on PS1778.
https://watch.screencastify.com/v/gy5oH4QRAB6Zvnfh3dZT

I’ll add this to the debug backlog so that it’s fixed.

Thank You!

[mparvazi]

Hello @HanaRebaiQA

The ps_reminder folder that is inside email themes renamed from followup to ps_reminder with this PR.

So that's why it's not exists in PS1778.

[mparvazi]

@hibatallahAouadni
I think this issue also is related to translations.

[MatShir]

Nice catch @mparvazi, but here the cleaning code around the archived module is considered as an improvement. The code has no impact on the ecosystem, so this enhancement must be done on the development branch.

[mparvazi]

@MatShir
I definitely agree with you!

[boubkerbribri]

It's the same for followup module, there is a new folder added by this PR that should be deleted.