Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove archived modules from email themes #34309

Merged
merged 1 commit into from Oct 23, 2023
Merged

Remove archived modules from email themes #34309

merged 1 commit into from Oct 23, 2023

Conversation

micka-fdz
Copy link
Contributor

@micka-fdz micka-fdz commented Oct 17, 2023 •
edited by Progi1984

Questions Answers
Branch? develop
Description? Remove archived modules from classic and modern email themes.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
How to test? Emails from these modules should no longer be generated.
UI Tests -
Fixed issue or discussion? Fixes #27084
Related PRs -
Sponsor company @Creabilis

@micka-fdz micka-fdz requested review from a team as code owners October 17, 2023 08:57
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Oct 17, 2023
@micka-fdz
Copy link
Contributor Author

Hi @boubkerbribri @Progi1984, this PR is about your comments here: #27544

Progi1984
Progi1984 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for UI Tests

@micka-fdz
Copy link
Contributor Author

This PR seems ready to merge 🎉

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Oct 19, 2023
@florine2623 florine2623 self-assigned this Oct 19, 2023
florine2623
florine2623 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA ✅

No more emails for ps_reminder and followup

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Oct 23, 2023
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@kpodemski kpodemski added this to the 9.0.0 milestone Oct 23, 2023
@kpodemski kpodemski merged commit b494f3f into PrestaShop:develop Oct 23, 2023
24 checks passed
@kpodemski
Copy link
Contributor

thanks @micka-fdz

@micka-fdz micka-fdz deleted the remove-modules-email-themes branch October 23, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@tleon tleon tleon approved these changes

@florine2623 florine2623 florine2623 approved these changes

@boherm boherm boherm approved these changes

@nesrineabdmouleh nesrineabdmouleh nesrineabdmouleh approved these changes

Assignees

@florine2623 florine2623

Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[BO] The ps_reminder module archived but still exists in email theme folder
9 participants
@micka-fdz @prestonBot @kpodemski @Progi1984 @tleon @florine2623 @boherm @nesrineabdmouleh @ps-jarvis