IMPROVE [BO]: improve error msg on (install\uninstall) module in case of dirty Override files

[ramtin2025]

Prerequisites

• I understand and accept the project's code of conduct
• I have already searched in existing issues and found no previous report of this bug.

Describe the bug and add screenshots

The methods inside the overridden classes has special comments for identification.
If, for any reason, these comments are deleted or changes are made in them that cause identification problems, the installation or uninstallation process will have the following error:
"Exception thrown by module on "ModuleName" reset. Error when resetting module "ModuleName". Notice: Undefined offset: -1"
This error is completely incomprehensible and does not suggest any path to identify the problem.
Putting a condition before this line can help identify this error:
If ($line_number<5) { // some code to display error about override conflict }
PrestaShop github

Expected behavior

Exception thrown by module on "ModuleName" reset. Error when resetting module "ModuleName". Notice: Override/Classes/Product.php is dirty

Steps to reproduce

1. Install a module that has an override
2. Remove comments on overrided class
3. Try to uninstall the above module

PrestaShop version(s) where the bug happened

1.7.8.5

PHP version(s) where the bug happened

7.4

If your bug is related to a module, specify its name and its version

No response

[hibatallahAouadni]

Hello @ramtin2025

Thanks for reporting the issue!
Could you please provide a test module to help me up reproducing the issue 🙏
Waiting for your feedback.

Thanks!

[ramtin2025]

Hello @ramtin2025

Thanks for reporting the issue! Could you please provide a test module to help me up reproducing the issue 🙏 Waiting for your feedback.

Thanks!

I attach a sample simple module with one overrided method in "Product.php" file.

1. Install module
2. Remove below lines from Root/override/classes/Product.php
   /*
   • module: test_override
   • date: 2022-- ::**
   • version: 1.0.0
     */
3. Try to uninstall Module
   Note: Note that the "Product" class does not already have an override

test_override.zip

[hibatallahAouadni]

Hello @ramtin2025

Thanks for the module 🙏
I reproduce the issue with PS1786, PS1787 and PS80x see the attached screen record below:

issue_29393.mp4

While with PS1778, the module has been uninstalled without any error, so it's a regression on 1.7.8.0!
I’ll add this to the debug backlog so that it’s fixed.

Please be aware that due to the high number of reported issues, some bugs might take a very long time to be resolved. If this issue is important to you and you cannot wait for it to be fixed on the project’s own time, we strongly suggest you consider hiring a specialist to help you.

If you manage to get the problem fixed, then please contribute the fix back to the project as a Pull Request. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thank you

[ramtin2025]

Hello @ramtin2025

Thanks for the module 🙏 I reproduce the issue with PS1786, PS1787 and PS80x see the attached screen record below:

issue_29393.mp4
While with PS1778, the module has been uninstalled without any error, so it's a regression on 1.7.8.0! I’ll add this to the debug backlog so that it’s fixed.

Please be aware that due to the high number of reported issues, some bugs might take a very long time to be resolved. If this issue is important to you and you cannot wait for it to be fixed on the project’s own time, we strongly suggest you consider hiring a specialist to help you.

If you manage to get the problem fixed, then please contribute the fix back to the project as a Pull Request. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thank you

Thank you.
Note that in the above example (provided test module), if you already have an override in a "product.php" class, an error will not be displayed. Of course, this does not mean that there is no problem, but the existence of a problem does not cause an error. Therefore, I am not sure that this problem does not exist in version 1.7.7.8 in your test.
I would like to help in solving this problem, but the collaboration process in GitHub is a bit difficult and time consuming. I'll try

[hibatallahAouadni]

Hello @ramtin2025

Note that in the above example (provided test module), if you already have an override in a "product.php" class, an error will not be displayed. Of course, this does not mean that there is no problem, but the existence of a problem does not cause an error.
Therefore, I am not sure that this problem does not exist in version 1.7.7.8 in your test.

I confirm that while retesting the issue on a newly created shop 1.7.7.0, I reproduce the issue. So it's an old bug!

Thanks!