Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure new image format for the new image system #29893

Closed
5 of 6 tasks
MatShir opened this issue Oct 5, 2022 · 1 comment · Fixed by #30045
Closed
5 of 6 tasks

Configure new image format for the new image system #29893

MatShir opened this issue Oct 5, 2022 · 1 comment · Fixed by #30045
Assignees
Labels
BO Category: Back Office Feature Type: New Feature Image Label: Which BO under menu is concerned
Milestone

Comments

@MatShir
Copy link
Contributor

MatShir commented Oct 5, 2022

Prerequisites

Is your feature request related to a problem?

New configuration for image generation.
We need to be able to generate multiple image formats, instead of single ones.
The current settings "Image format" will be improved.

Describe the solution you'd like

By default, at the shop creation, JPEG and WebP are selected.
JPEG is used as the default format.

Image

The form presents 4 checkboxes.

  • JPEG
  • PNG
  • WebP
  • AVIF

One option must remain selected.
If a user deselects all options, the last option is disabled. It is not possible to deselect it.

The fallback allows the user to choose a format that will be supported by all the browser in case the image type selected are not compatible.

The fallback drop list is a dynamic list that lists all the image type checked in the checkbox list.
If the user unchecked the image type used for the fallback then the first checked format in the list is selected as fallback

If the server does not support AIF
Then disable the AVIF option and display a warning message and a link to an external documentation (to the avif documentation). Link to be defined.

Image

If more than 3 image option are select then
A warning message: "Beware the selection of several image formats leads to a higher memory capacity requirement and impacts the performance during generation"

Image

The form will have a new input to manage the quality of avif.

  • AVIF compression - number input - by default the input is set to 30.
    Label: "Ranges from 0 (worst quality, smaller file) to 100 (best quality, larger file). Recommended: 30."

If the value when saving the form is higher than 100 or lower than 0
Then an error message is displayed: "Incorrect value for the selected AVIF image compression." and the form is not validated.

Business rule

When an image is uploaded, it generates the image is selected format.

Alternatives you've considered

No response

Additional context

No response

Do you plan to work on this feature?

  • I'm willing to contribute a formal specification.
  • I'm willing to provide any wireframes or design assets required for this feature.
  • I'm willing to submit a Pull Request that implements this feature.
  • I'm willing to help verify that the implemented feature works as intended and produces no unintended side effects.
@MatShir MatShir added Feature Type: New Feature New New issue not yet processed by QA Waiting for UX Status: action required, waiting for design feedback Needs Specs Status: issue needs to be specified Image Label: Which BO under menu is concerned and removed New New issue not yet processed by QA labels Oct 5, 2022
@hibatallahAouadni hibatallahAouadni added BO Category: Back Office and removed New New issue not yet processed by QA labels Oct 5, 2022
@nicosomb nicosomb self-assigned this Nov 15, 2022
@MatShir MatShir added Ready Status: Issue is ready to be worked on and removed Waiting for UX Status: action required, waiting for design feedback Needs Specs Status: issue needs to be specified labels Nov 17, 2022
@Hlavtox
Copy link
Contributor

Hlavtox commented Dec 13, 2022

@nicosomb @MatShir I think that we are missing a checkbox called "JPG/PNG depending on the original image" in the design.

Now we have 3 options:

  • JPG or PNG, depending on the original image. (or rather if the original image was transparent?)
  • JPG
  • PNG
    (note: all have JPG extension, even though they contain a PNG image)

@prestashop-issue-bot prestashop-issue-bot bot removed the Ready Status: Issue is ready to be worked on label Jan 23, 2023
@Progi1984 Progi1984 added this to the 8.1.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BO Category: Back Office Feature Type: New Feature Image Label: Which BO under menu is concerned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants