Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect number of columns when filtering in Shopping Carts page #29894

Closed
2 tasks done
Tracked by #31493
Progi1984 opened this issue Oct 5, 2022 · 4 comments · Fixed by #30380
Closed
2 tasks done
Tracked by #31493

Incorrect number of columns when filtering in Shopping Carts page #29894

Progi1984 opened this issue Oct 5, 2022 · 4 comments · Fixed by #30380
Assignees
Labels
BO Category: Back Office Detected by TE Issue detected by TE Feature Type: New Feature Fixed Resolution: issue closed because fixed PR available Solution: issue is being addressed Shopping carts Label: Which BO under menu is concerned
Milestone

Comments

@Progi1984
Copy link
Contributor

Prerequisites

Describe the bug and add screenshots

In Shopping Carts page, if I filter on Numeric in Order ID, there are 8 columns rather than 9.

Expected behavior

If I filter on Numeric in Order ID, there are 9 columns.

Steps to reproduce

  1. In BO, go to Shopping Carts page
  2. There are 9 columns :
    image
  3. If I filter on Abandoned carts, there are 9 columns
    image
  4. If I filter on Numeric in Order ID, there are 8 columns
    image

PrestaShop version(s) where the bug happened

8.0.0

PHP version(s) where the bug happened

No response

If your bug is related to a module, specify its name and its version

No response

@Progi1984 Progi1984 added Bug Type: Bug Shopping carts Label: Which BO under menu is concerned Detected by TE Issue detected by TE New New issue not yet processed by QA labels Oct 5, 2022
@hibatallahAouadni
Copy link
Contributor

Hello @Progi1984

This is the expected behavior, because when looking for a valid cart (which you can't delete), then you won't have a column for delete checkboxes.
Closing the issue as it's not a bug.

Thanks!

@hibatallahAouadni hibatallahAouadni added Invalid Resolution: issue closed because invalid BO Category: Back Office 1.7.7.0 Affects versions and removed New New issue not yet processed by QA labels Oct 5, 2022
@Progi1984
Copy link
Contributor Author

@hibatallahAouadni We discuss with @PrestaShop/qa-automation and we think we should have an empty column. Isn't it ?

@eshraw
Copy link

eshraw commented Oct 6, 2022

Hey 👋
Thanks for the issue @Progi1984 .

As this page has yet to be migrated (#10584) this falls in the improvement category (unless we have a clear regression from a past version).

Regarding the expected behaviour, according to UX principles we should value consistency over a cleaner look. As a result, we indeed need to stick with 9 columns in every table display in this page, even if that means we'll end up with an empty column in some cases.

I think that an UX review of this table might be a good thing to couple to the page migration @TristanLDD .

@hibatallahAouadni hibatallahAouadni added Waiting for UX Status: action required, waiting for design feedback Feature Type: New Feature Needs Specs Status: issue needs to be specified and removed Bug Type: Bug 1.7.7.0 Affects versions Invalid Resolution: issue closed because invalid labels Oct 6, 2022
@ElodieOS
Copy link

Hello everyone!

For a quick action, I agree with @eshraw, we need to keep consistency regardless of the state to not lose the user.

In the long term, I think we need to rework the ux of the data tables in general (several issues on it), but if you want a quick action, eshane's proposal is good :)

@prestonBot prestonBot added the PR available Solution: issue is being addressed label Nov 23, 2022
@Progi1984 Progi1984 self-assigned this Nov 23, 2022
@Progi1984 Progi1984 added this to the 8.1.0 milestone Nov 23, 2022
@prestashop-issue-bot prestashop-issue-bot bot removed the Needs Specs Status: issue needs to be specified label Nov 30, 2022
@hibatallahAouadni hibatallahAouadni added Fixed Resolution: issue closed because fixed and removed Waiting for UX Status: action required, waiting for design feedback labels Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BO Category: Back Office Detected by TE Issue detected by TE Feature Type: New Feature Fixed Resolution: issue closed because fixed PR available Solution: issue is being addressed Shopping carts Label: Which BO under menu is concerned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants