Missing translations in ps_emailalertsv2.4.0 from dev branch

[lmeyer1]

Prerequisites

• I understand and accept the project's code of conduct
• I have already searched in existing issues and found no previous report of this bug.

Describe the bug and add screenshots

There are several missing translations in the FO for ps_emailalerts.
The most visible is the confirmation text that displays after submitting a request for an alert.

Expected behavior

I expect the module to be completely translated to French and German

Steps to reproduce

1. Set your shops language to French or German
2. From module manager > Uninstall ps_emailalerts v2.3.3

3. Install and activate ps_emailalerts v2.4.0 from dev branch 
4. Under modules > git clone git@github.com:PrestaShop/ps_emailalerts.git
5. cd ps_emailalerts > composer install

6. In the BO, ps_emailalerts configurations, activate Customer notifications for Product availability.
7. In the FO navigate to a product that is out of stock.
8. Notice the box that allows to subscribe:
   
9. Subscribe. Notice that the confirmation message is in English.
   

Checking the files app/Resources/translations/default/ModulesEmailalerts*.xlf and the source files of the module, I notice that all the strings in modules/ps_emailalerts/controllers/front/actions.php are missing in the .xlf file.

PrestaShop version(s) where the bug happened

1.7.8.7

PHP version(s) where the bug happened

7.4

If your bug is related to a module, specify its name and its version

ps_emailalerts 2.4.0 from dev branch

[florine2623]

Hello @lmeyer1 ,

I can't reproduce your issue. Tested in French, English and German with the same config as you. PS 1.7.8.7, PHP 7.4 and ps_emailalerts 2.3.3.

Screen.Recording.2022-11-07.at.14.30.56.mov

Is there something I am missing ?
Waiting for your feedback.

[lmeyer1]

Hello @florine2623,
Oh I forgot, this is my PR's fault.
v2.3.3 does not have this problem.
dev branch has this problem since here PrestaShop/ps_emailalerts@e944692
I fixed on thing and broke another.

[florine2623]

Alright ^^
I tested with branch dev of the module ps_emailalerts, but I still can't reproduce the issue 🤔

So can I close this issue ?
Or do you want to create a PR to fix the issue since PrestaShop/ps_emailalerts@e944692 ?
If that's the case, I will need the help from my fellow @PrestaShop/qa-functional. If one of youc an reproduce the issue that would be great !

[lmeyer1]

Hello @florine2623
I am not able to reproduce with https://github.com/PrestaShop/ps_emailalerts/releases/tag/v2.3.3
But I'm able to reproduce with https://github.com/PrestaShop/ps_emailalerts/archive/refs/heads/dev.zip
I remember vaguely to have discussed about this with @Julievrz some months ago. I have to look into the archives.

[sallemiines]

Hello @lmeyer1

I try to reproduce the issue with [ps_emailalerts-dev.zip], as you said , but unfortunately I can't install the module, see the attached screenshot

Please check & feedback !
Thank you

[lmeyer1]

Hello @sallemiines,
To install a module downloaded from git in that way, you have to:

• unzip it
• move the files in a folder named with the module name (here /ps_emailalerts/)
• zip this folder (instead of the contents), and it will install.

[sallemiines]

@lmeyer1 , thank you for your feedback !
Well after following your steps and installing the module , in the FO , I can't find the box that allows to subscribe , see the attached screen record

Untitled_.Nov.8.2022.5_55.PM.webm

Did I miss something?
PLease check & feedback !

Thank you

[lmeyer1]

@sallemiines
Sorry, I don't know what is wrong in your installation. The box that allows to subscribe SHOULD display here.
Look with @florine2623, she was able to get the module working, see #30208 (comment).

[HanaRebaiQA]

Hello @lmeyer1

I tried to reproduce your issue with PS1787 using php 7.3 and php 7.4 and check with :

• ps_emailalerts v2.3.3 : OK (The issue is not reproduced) ✔️
• ps_emailalerts v2.4.0 from dev branch : NOK (The issue is reproduced) ❌

Also, i checked with PS8.0.x and i was able reproduce it with ps_emailalerts v2.4.0 from dev branch : NOK ❌

PS1787 - emailalerts v2.3.3 : OK ✔️

emailalerts.v2.3.3._.OK.mp4

PS1787 - emailalerts v2.4.0 : NOK ❌

emailalerts.v2.4.0.from.dev.branch._.NOK.mp4

PS8.0.x - emailalerts v2.4.0 : NOK ❌

It's a regression related to module ps_emailalerts
I'll add this to the debug backlog so that it's fixed.

Please be aware that due to the high number of reported issues, some bugs might take a very long time to be resolved. If this issue is important to you and you cannot wait for it to be fixed on the project's own time, we strongly suggest you consider hiring a specialist to help you.

If you manage to get the problem fixed, then please contribute the fix back to the project as a Pull Request. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thank You!

[HanaRebaiQA]

I've updated the issue description

[Bruno-2M]

translations are not working anymore :

before en 2.3.3 modules/ps_emailalerts/controllers/front/actions.php
'message' => $this->trans('Your e-mail address is invalid', [], 'Modules.Mailalerts.Shop'),
after in 2.4.0
'message' => $this->trans('Your e-mail address is invalid', [], 'Modules.Emailalerts.Shop'),

4 strings, same problem