Fix compatibility with psgdpr and ps >=1.7.8 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matks
approved these changes
Nov 24, 2022
matks
reviewed
Nov 24, 2022
Co-authored-by: Mathieu Ferment <mathieu.ferment@prestashop.com>
|
thanks @matks ! |
matks
approved these changes
Nov 25, 2022
hibatallahAouadni
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
Hello @marsaldev
Thanks for your PR 🚀
- PS 1.7.8.7 when the customer log in ✔️
- PS 1.7.8.7 when the customer log out ✔️
- PS 8.0.0 when the user is log in ✔️
- PS 8.0.0 when the user is log out ✔️
But as you can see the GDPR checkbox is not displayed because of this regression on 8.0.0 PrestaShop/PrestaShop#30348 (which is out of scope of this PR)
So, LGTM, QA ✔️
Thanks!
|
Thank you @marsaldev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registerGDPRConsenthook and an empty listenerHookRegisterGDPRConsent, otherwise the module is not psgdpr module compliant. This PR fix the compatibility of ps_emailalerts.