Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual issues on the new product page (mobile) #32218

Closed
2 tasks done
kpodemski opened this issue Apr 20, 2023 · 4 comments · Fixed by #35775
Closed
2 tasks done

Visual issues on the new product page (mobile) #32218

kpodemski opened this issue Apr 20, 2023 · 4 comments · Fixed by #35775
Assignees
Labels
8.1.x Branch BO Category: Back Office Bug Type: Bug Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Needs Specs Status: issue needs to be specified New Products Page Label: Which BO under menu is concerned PM ✔️ Status: check done, behavior approved Regression Type: regression Verified The issue has been reproduced

Comments

@kpodemski
Copy link
Contributor

Prerequisites

Describe the bug and add attachments

There are a few issues on mobile worth checking.

  1. Save and publish display problem.
    https://capture.dropbox.com/sNn0AT3eOBRYcCzN

  2. Three dots icon is not aligned correctly.
    https://capture.dropbox.com/b3owdasT9xJwIskM

  3. We could use a little more spacing there.
    https://capture.dropbox.com/xugYktCr23hUE0En

  4. Features are displayed in a very confusing way.
    https://capture.dropbox.com/99WqNlcGRvUq9eev

  5. Problems with "Add new file" popup.
    https://capture.dropbox.com/ZLJ0vVA1ETZz2eB3

  6. Customizable product. Problems with spacing and alignment.
    https://capture.dropbox.com/Wwtlef6xog066k7m

  7. It is impossible to edit the stock on a mobile device.
    https://capture.dropbox.com/dtjVuCfDQeHZ7mUN

  8. Alignment problem.
    https://capture.dropbox.com/Mw8BgK2GNY9XYWXw

  9. Incorrectly displayed prices.
    https://capture.dropbox.com/xu2plzoqvpek5GFZ

  10. Cost price displayed incorrectly (I'm aware that it's a tricky element to display, maybe a responsive table would be better).
    https://capture.dropbox.com/kHk2MsytitYtfaO4

Expected behavior

No response

Steps to reproduce

Visit the new product page, and places that you see on the screenshots.

PrestaShop version(s) where the bug happened

8.1.0

PHP version(s) where the bug happened

7.4

If your bug is related to a module, specify its name and its version

No response

Your company or customer's name goes here (if applicable).

No response

@kpodemski kpodemski added Bug Type: Bug New New issue not yet processed by QA labels Apr 20, 2023
@AureRita
Copy link
Contributor

Hi @kpodemski

Thank you for your report, I reproduced some of them :

We could use a little more spacing there.

image

For the number four,with add new file, I've a "had new file ception" as you can see :

Untitled_.Apr.20.2023.5_01.PM.webm

and I have your issue

image

Customizable product. Problems with spacing and alignment.

image

For the number six, you currently can add stocks but it's a little be hidden :

Untitled_.Apr.20.2023.5_09.PM.webm

Alignment problem.

image

Incorrectly displayed prices.

image


But with some of them I didn't reproduce it,
Did you do a hard refresh on the page with mobile system ?

as you can see :

Save and publish display problem.

image

Three dots icon is not aligned correctly.

image

Features are displayed in a very confusing way.

image

Cost price displayed incorrectly (I'm aware that it's a tricky element to display, maybe a responsive table would be better).

image


Some of these issue can be directly corrected, but some of them (like the button placement) should be checked by PM

Thank you

@AureRita AureRita added Waiting for PM Status: action required, waiting for product feedback Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification BO Category: Back Office Needs Specs Status: issue needs to be specified Old Products Page Concerns the old product page Verified The issue has been reproduced 8.1.x Branch and removed New New issue not yet processed by QA labels Apr 20, 2023
@hibatallahAouadni hibatallahAouadni added the Regression Type: regression label May 3, 2023
@MatShir MatShir added New Products Page Label: Which BO under menu is concerned Waiting for UX Status: action required, waiting for design feedback and removed Old Products Page Concerns the old product page Waiting for PM Status: action required, waiting for product feedback labels Nov 3, 2023
@ElodieOS
Copy link

ElodieOS commented Jan 5, 2024

Hello @kpodemski,

Like @AureRita said, some of issues can be directly corrected and I am agree with these propositions.

For the 8: "incorrectly display prices", we already have an issue which is resolved (for UX phase): #34675

I made mockup for 5 and 6 and I add the mockup for the 8

Wdyt?

image

@mattgoud
Copy link
Contributor

I'm watching

@MatShir MatShir added PM ✔️ Status: check done, behavior approved and removed Waiting for UX Status: action required, waiting for design feedback labels Mar 21, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Mar 25, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Mar 25, 2024
…hree dots alignement (product header), switch alignement (product details - show_condition)
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Mar 25, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Mar 25, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Mar 26, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Mar 27, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Mar 27, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Mar 27, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Mar 27, 2024
@mattgoud
Copy link
Contributor

For number 4, I created a separate issue : #35765

mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 9, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 9, 2024
@jolelievre jolelievre linked a pull request Apr 9, 2024 that will close this issue
@WahbiPS WahbiPS added the Waiting for QA Status: action required, waiting for test feedback label Apr 19, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 26, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 26, 2024
…hree dots alignement (product header), switch alignement (product details - show_condition)
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 26, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 26, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 26, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 26, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 26, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 26, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 26, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 26, 2024
mattgoud added a commit to mattgoud/PrestaShop that referenced this issue Apr 26, 2024
@MatShir MatShir removed the Waiting for QA Status: action required, waiting for test feedback label May 16, 2024
@MatShir MatShir closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.1.x Branch BO Category: Back Office Bug Type: Bug Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Needs Specs Status: issue needs to be specified New Products Page Label: Which BO under menu is concerned PM ✔️ Status: check done, behavior approved Regression Type: regression Verified The issue has been reproduced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants