Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle legacy page display via the Symfony controller automatically and systematically #32981

Closed
Tracked by #32875
fabienvallon opened this issue Jun 22, 2023 · 2 comments
Labels
9.0.x Branch CO Category: Core Symfony layout Task Type: neither a bug or a feature

Comments

@fabienvallon
Copy link

fabienvallon commented Jun 22, 2023

Blocked by #32980

Description

Once #32980 is done and the controller is available we can then remove the principle based on RouteNotFoundException in the index.php file, any URL even the legacy ones would be handled via Symfony

Some generic route mapping will need to be found to catch the legacy URLs, the URL should not change to avoid breaking changes, it's just that the layout would now be handled by Symfony. This will simplify the work about authentication by Symfony a lot since after this ALL the pages (including the legacy ones) would be handled by the framework.

Example:

legacy_controller_route:
  path: /controller={controllerName}
  defaults:
    _controller: LegacyLayoutController::legacyPageAction

Acceptance test

UI tests work fine with symfony layout enabled even on legacy pages

Blocked by #32980

@fabienvallon fabienvallon changed the title Once this controller is available we can then remove the principle based on RouteNotFoundException in the index.php file, any URL even the legacy ones would be handled via Symfony Some generic route mapping will need to be found to catch the legacy URLs, the URL should not change o avoid breaking changes, it's just that the layout would now be handled by Syfony. This will simplify the work about authentication by Symfony a a lot since after this ALL the pages (including the legacy ones) would be handled by the framework. Replace legacy Layout ( Part 2) Jun 22, 2023
@jolelievre jolelievre changed the title Replace legacy Layout ( Part 2) Handle legacy page display via the Sylfony controller automatically and systematically Jun 22, 2023
@jolelievre jolelievre changed the title Handle legacy page display via the Sylfony controller automatically and systematically Handle legacy page display via the Symfony controller automatically and systematically Jun 22, 2023
@fabienvallon fabienvallon changed the title Handle legacy page display via the Symfony controller automatically and systematically [Replacing layout in legacy pages] Handle legacy page display via the Symfony controller automatically and systematically Jul 7, 2023
@jolelievre jolelievre changed the title [Replacing layout in legacy pages] Handle legacy page display via the Symfony controller automatically and systematically Handle legacy page display via the Symfony controller automatically and systematically Jul 10, 2023
@jolelievre jolelievre added Task Type: neither a bug or a feature New New issue not yet processed by QA 9.0.x Branch labels Jul 10, 2023
@hibatallahAouadni hibatallahAouadni added CO Category: Core Needs Specs Status: issue needs to be specified and removed New New issue not yet processed by QA labels Jul 11, 2023
@MatShir
Copy link
Contributor

MatShir commented Aug 21, 2023

Final boss

@MatShir
Copy link
Contributor

MatShir commented Jan 12, 2024

closed in favor of #32980

@MatShir MatShir closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2024
@prestashop-issue-bot prestashop-issue-bot bot removed the Needs Specs Status: issue needs to be specified label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0.x Branch CO Category: Core Symfony layout Task Type: neither a bug or a feature
Projects
None yet
Development

No branches or pull requests

4 participants