[Epic] Symfony Layout #32875
Labels
Comments
hibatallahAouadni
added
EPIC
13 tasks
|
People curious about this topic can read https://build.prestashop-project.org/news/2019/prestashop-in-2019-and-beyond-part-2-pain-points/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Symfony layout was initialized in this PR https://github.com/PrestaShop/PrestaShop/pull/32235/files it is meerly a POC that initializes this new feature, from this PR a lot of work is still left to do, some components must be added, some refacto is needed. This epic lists all the tasks eft to do for this feature to be full and for the Syfony layout to replace completely the legacy one.
Replacing legacy components
<head></head>) #33103php_errors#33088head></head>) #33183Create the Symfony/twig default layout
LayoutBuilderservice for Symfony layout #33138Replacing layout in legacy pages
Improvement about Context
AdminController::initShopContextinLegacyContext::getContext#33193Small refacto less impactful or less related
LegacyControllerBridge(but in many other places, legacy and modern) the base URI depends on the shop from the context$this->legacyContext->getContext()->shop->getBaseURI()(but not only the URI depends on the shop), this can be problematic since it means if the DB is not set, not accessible or the Shop is not defined correctly the base URI of the whole BO is not accessible, and it also can not even be deduced from a CI perspective or for CLI commands without access to the database. We should think if this could be improved, maybe base this data on a configuration but that's a very simple suggestion that needs to be thought more deeply, and we should keep in mind the multishop problematic in this reflection.Layout variables cleanup (probably not relevant anymore but kept here for now)
ControllerConfigurationwill probably need to be refactored and cleaned For now, many legacy variables have been integrated for backward compatibility purposes without much reflection, but some are probably useless in a new twig theme. We should investigate which are still relevant, and which ones could be removed (keeping in mind that some modules may depend on them, any variable removed should have a legitimate alternative)ControllerConfigurationthat was introduced during the horizontal migration POC many variables are injected in the template's variables, some directly inSymfonyLayoutExtensionthat contains complete smart rendered templates used in the legacy layout (but maybe not useful anymore, or that could be refactored and rendered via twig components instead), and many more are built vie the Configurators that populateControllerConfiguration::templateVarsproperty, some investigation is needed about these variables to detect which were purely related to the legacy layout and can be removed, which should be replaced by more modern components/variables/alternatives, and which are really mandatory and need to be kept but maybe refactoredSymfonyLayoutExtensioninjects some blocks based on smarty, mostly modals, but it is also used to set some hard-coded smarty variables maybe it's not the right place, and maybe those modals should be removed completely. The extension should mostly be about setting global variables from the controller configuration. Although it's quite useful and easy to do it this way maybe it's not an ideal way (part of ControllerConfiguration refacto).@PrestaShop/Admin/Layout/default_layout.html.twigwas mostly built based onadmin-dev/themes/new-theme/template/layout.tplthe initial purpose is to keep the same markup as the previous to avoid unexpected side effects. But it may be interesting to refactor it later with better variables naming, maybe some pieces won't be relevant anymore. We should consider if the new variables are useful for legacy purposes (modules, overrides, ...) and if we need to keep the old names for backward compatibility. (this task is related to the first one about controller/layout variables)@PrestaShop/Admin/Layout/header.html.twiga lot of javascript variables are initialized, some of them may become useless.@PrestaShop/Admin/Layout/page_header_toolbar.html.twigcan probably be optimized/simplified It seems like buttons are displayed twice for some reasonThe text was updated successfully, but these errors were encountered: