Regarding 33047 - Issue with missing id_employee in ps_order_payment table

[Johnnyx2010]

Prerequisites

• I understand and accept the project's code of conduct.
• I have already searched in existing issues and found no previous report of this bug.

Describe the bug and add attachments

I'm logging this here as it was previously logged at 33047. However its unclear was this ticket closed due the poster finding a solution via a manual entry in the db or was this logged as a fix todo at the upgrade level.
On a PS 1.7 there is no id_employee field. So when we upgrade to ps8 this field isn't present. This field needs to be part of the upgrade script as is important as third party modules can use this table.

Expected behavior

id_employee to be added on ps_order_payment table via an upgrade script from 1.7 to PS 8

Steps to reproduce

Upgrade existing PS 1.7 to PS 8 - check for the id_employee field its missing in ps_order_payment table. Clean install of PS8 has this field in the table

PrestaShop version(s) where the bug happened

8

PHP version(s) where the bug happened

8.1

If your bug is related to a module, specify its name and its version

upgrade script

Your company or customer's name goes here (if applicable).

NA

[florine2623]

Hello @Johnnyx2010 ,

Could you specify the exact version of PrestaShop before your upgrade ?
As well as send a screenshot of your error ?

The previous issue was closed because it couldn't be reproduced : #33047 (comment)

Waiting for your feedback^^

[Johnnyx2010]

its ps 1.7.8.9.
upgrade it to straight to 8.1
Have a look at https://github.com/PrestaShop/PrestaShop/blob/1.7.8.x/install-dev/data/db_structure.sql - there's no mention of the field here
https://github.com/PrestaShop/PrestaShop/blob/8.1.x/install-dev/data/db_structure.sql - line 1594 the field is added

[BenTen]

It's a recent update of the structure. It does not exist before 8.1

• Add employee info on the Payments tab when payment is registered #28820

@okom3pom said "Don't forget autoupgrade."
#28820 (review)

As well as send a screenshot of your error ?

It is an issue with autoupgrade who doesn't update this table.
https://github.com/PrestaShop/autoupgrade/blob/dev/upgrade/sql/8.1.0.sql

[aniszr]

Hello,

Thanks for reporting this issue!
Ping @PrestaShop/prestashop-core-developers: Could someone please try to reproduce the issue, it's too technical!

Thanks in advance!

[kpodemski]

I can confirm this issue.

[kpodemski]

@MatShir @RosaBenouamer @Zoefinders @fabienvallon

The important, easy solvable issue for the autoupgrade module.

[ocio87]

I add the following Bug that was closed that is associated with the same problem:

#33118

By having an initial state checking boxes where it is reported that it was paid, it throws an error 500.

In addition to adding a payment in orders orders. It fails to add the payment and the ps_order_payment table fails to insert rows.

Please check if they are independent issues and leave the Bug that I reported as a duplicate.

[BenTen]

@ocio87

You have to do that
#33047 (comment)

or ask someone or wait the update.

[FlyMeFR]

Thanks a lot, it worked !

[ocio87]

@ocio87

You have to do that #33047 (comment)

or ask someone or wait the update.

Thanks, if it worked with the change.

Does this change not affect future updates where prestashop includes this field?

[LuigiMdg]

Same problem here, ok that just add the column and it works, but the point of this column?
No value is recorded in it.

[ocio87]

when payment is added from orders, it shows the employee who made the deposit.

[Hlavtox]

Issue will be resolved after release of new version of autoupgrade module.
For existing upgrades, you can fix the issue permanently by running this SQL.

ALTER TABLE `ps_order_payment` ADD `id_employee` INT NULL AFTER `date_add`;