Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Independent twig component: Header (from head></head>) #33183

Closed
Tracked by #32875
, #33101
...
jolelievre opened this issue Jul 10, 2023 · 0 comments · Fixed by #33775
Closed
Tracked by #32875
, #33101
...

Independent twig component: Header (from head></head>) #33183

jolelievre opened this issue Jul 10, 2023 · 0 comments · Fixed by #33775
Assignees
@M0rgan01
Labels
9.0.x Branch CO Category: Core Symfony layout Task Type: neither a bug or a feature

Comments

@jolelievre
Copy link
Contributor

jolelievre commented Jul 10, 2023 •
edited

Description

See #33101 for description in Step 2

This is the header part (<head></head>).

This component should be quite autonomous.

Additional note

Header template

The header was initially created/rendered via AdminController::display method So basically from the content of https://github.com/PrestaShop/PrestaShop/blob/9f23933ac4cde3c982c3f2cff14c300acac1256f/admin-dev/themes/new-theme/template/header.tpl#L34-L33

Controller API
But it also relies a lot on the content added via AdminController::addCss and AdminController::addJs which are also used by modules, so this content must still be editable/customizable from the modules and still be injected in the header part.

Controller setMedia
Finally, the switch between default and new theme relies a lot on AdminController::setMedia which is usually called with the parameter true, we shouldn't rely on this anymore. Instead the basic css/js files required for the new theme should be added in the header twig file direct via the asset method. We will always force new theme and its dependencies so we can hard code them.

Blocked by #33103
@jolelievre jolelievre mentioned this issue Jul 10, 2023
Closed
41 tasks
@jolelievre jolelievre added Task Type: neither a bug or a feature New New issue not yet processed by QA 9.0.x Branch Symfony layout labels Jul 10, 2023
@jolelievre jolelievre mentioned this issue Jul 10, 2023
Closed
22 tasks
@jolelievre jolelievre changed the title Independent twig component: Header Independent twig component: Header (from head></head>) Jul 11, 2023
@hibatallahAouadni hibatallahAouadni added CO Category: Core Blocked Status: The issue is blocked by another task and removed New New issue not yet processed by QA labels Jul 12, 2023
@M0rgan01 M0rgan01 self-assigned this Aug 24, 2023
@M0rgan01 M0rgan01 mentioned this issue Aug 30, 2023
Merged
@prestashop-issue-bot prestashop-issue-bot bot removed the Blocked Status: The issue is blocked by another task label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@M0rgan01 M0rgan01

Labels
9.0.x Branch CO Category: Core Symfony layout Task Type: neither a bug or a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Twig component: Make Header independent M0rgan01/PrestaShop
3 participants
@jolelievre @hibatallahAouadni @M0rgan01