Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle session message inter-compatible between legacy and symfony pages #33192

Closed
Tracked by #32875
jolelievre opened this issue Jul 10, 2023 · 0 comments · Fixed by #33214
Closed
Tracked by #32875

Handle session message inter-compatible between legacy and symfony pages #33192

jolelievre opened this issue Jul 10, 2023 · 0 comments · Fixed by #33214
Assignees
@lartist
Labels
9.0.x Branch CO Category: Core PR available Solution: issue is being addressed Ready Status: Issue is ready to be worked on Symfony layout Task Type: neither a bug or a feature

Comments

@jolelievre
Copy link
Contributor

jolelievre commented Jul 10, 2023 •
edited

Description

Error / information / confirmation / warning messages all have a dedicated smarty template in the legacy layout

These four could maybe be removed, and instead we should rely on Symfony session messages used in most layouts already, but they also should be compatible with messages sent from a legacy controller

So a bridge should probably be set in place so that a message from a legacy controller is correctly displayed by Symfony/twig flash bah messages. Then they would completely replace the legacy once in both migrated AND legacy pages.
@jolelievre jolelievre mentioned this issue Jul 10, 2023
Closed
41 tasks
@jolelievre jolelievre added Task Type: neither a bug or a feature New New issue not yet processed by QA 9.0.x Branch Symfony layout labels Jul 10, 2023
@hibatallahAouadni hibatallahAouadni added CO Category: Core Ready Status: Issue is ready to be worked on and removed New New issue not yet processed by QA labels Jul 12, 2023
@lartist lartist self-assigned this Jul 12, 2023
@lartist lartist mentioned this issue Jul 12, 2023
Merged
@prestonBot prestonBot added the PR available Solution: issue is being addressed label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lartist lartist

Labels
9.0.x Branch CO Category: Core PR available Solution: issue is being addressed Ready Status: Issue is ready to be worked on Symfony layout Task Type: neither a bug or a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flash messages Bridge from legacy to Symfony lartist/PrestaShop
4 participants
@lartist @jolelievre @prestonBot @hibatallahAouadni