Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade egulias/email-validator #33445

Closed
WahbiPS opened this issue Jul 27, 2023 · 8 comments
Closed

Upgrade egulias/email-validator #33445

WahbiPS opened this issue Jul 27, 2023 · 8 comments
Assignees
@matthieu-rolland @M0rgan01
Labels
CO Category: Core Email Label: Which BO under menu is concerned PR available Solution: issue is being addressed Task Type: neither a bug or a feature

Comments

@WahbiPS
Copy link

WahbiPS commented Jul 27, 2023 •
edited

Check if JS lib should be updated.
@WahbiPS WahbiPS added CO Category: Core Task Type: neither a bug or a feature labels Jul 27, 2023
@M0rgan01 M0rgan01 mentioned this issue Jul 27, 2023
Merged
@prestonBot prestonBot added the PR available Solution: issue is being addressed label Jul 27, 2023
@hibatallahAouadni hibatallahAouadni added WIP Status: Work In Progress Email Label: Which BO under menu is concerned labels Jul 28, 2023
@matks
Copy link
Contributor

matks commented Jul 31, 2023

The work will be a lot more complex than expected, see #33511

@WahbiPS
Copy link
Author

WahbiPS commented Aug 1, 2023 •
edited

Blocked, waiting for discussion above

@M0rgan01
Copy link
Contributor

M0rgan01 commented Aug 3, 2023 •
edited

Requires modules upgrades:

Main PR: #33459

@M0rgan01 M0rgan01 mentioned this issue Aug 3, 2023
Merged
@M0rgan01
Copy link
Contributor

M0rgan01 commented Aug 4, 2023 •
edited by WahbiPS

The upgrade of the email-validator library required an update of several Doctrine libraries, which complicated the task. The majority of the changes come from Doctrine DBAL (https://github.com/doctrine/dbal/blob/3.6.x/UPGRADE.md). All native modules also need to be checked.

  • autoupgrade
  • blockreassurance
  • blockwishlist
  • contactform
  • dashactivity
  • dashgoals
  • dashproducts
  • dashtrends
  • followup
  • graphnvd3
  • gridhtml
  • gsitemap
  • pagesnotfound
  • productcomments
  • ps_banner
  • ps_bestsellers
  • ps_brandlist
  • ps_cashondelivery
  • ps_categoryproducts
  • ps_categorytree
  • ps_checkpayment
  • ps_contactinfo
  • ps_crossselling
  • ps_currencyselector
  • ps_customeraccountlinks
  • ps_customersignin
  • ps_customtext
  • ps_dataprivacy
  • ps_distributionapiclient
  • ps_emailalerts
  • ps_emailsubscription
  • ps_facetedsearch
  • ps_faviconnotificationbo
  • ps_featuredproducts
  • psgdpr
  • ps_googleanalytics
  • ps_imageslider
  • ps_languageselector
  • ps_linklist
  • ps_mainmenu
  • ps_newproducts
  • ps_reminder
  • ps_searchbar
  • ps_sharebuttons
  • ps_shoppingcart
  • ps_socialfollow
  • ps_specials
  • ps_supplierlist
  • ps_themecusto
  • ps_viewedproduct
  • ps_wirepayment
  • referralprogram
  • statsbestcategories
  • statsbestcustomers
  • statsbestmanufacturers
  • statsbestproducts
  • statsbestsuppliers
  • statsbestvouchers
  • statscarrier
  • statscatalog
  • statscheckup
  • statsdata
  • statsforecast
  • statsnewsletter
  • statspersonalinfos
  • statsproduct
  • statsregistrations
  • statssales
  • statssearch
  • statsstock

@matthieu-rolland matthieu-rolland self-assigned this Aug 8, 2023
@WahbiPS
Copy link
Author

WahbiPS commented Aug 21, 2023

Blocked by this PrestaShop/productcomments#180

@matks
Copy link
Contributor

matks commented Sep 5, 2023

Now awaiting for ps_linklist 6.0.4 release PrestaShop/ps_linklist#183

@matks
Copy link
Contributor

matks commented Sep 13, 2023

This topic is blocked because PR #33459 is blocked

We have Sanity tests failing and it seems this is not due to a real problem*, but rather something to improve in Sanity tests.

*We attempted to follow the test steps on a real shop and could not observe the bug symptoms.

@jolelievre first attempted to do PR PrestaShop/ga.tests.ui.pr#47 but it did not work

Another attempt PrestaShop/ga.tests.ui.pr#44 that might help solving the problem

If PR PrestaShop/ga.tests.ui.pr#44 does not solve the problem, we need to decide on what we do to unblock this topic with. People that need to be included in the discussion

@MatShir MatShir closed this as completed Sep 29, 2023
@prestashop-issue-bot prestashop-issue-bot bot removed the WIP Status: Work In Progress label Sep 29, 2023
@matks
Copy link
Contributor

matks commented Sep 29, 2023

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthieu-rolland matthieu-rolland

@M0rgan01 M0rgan01

Labels
CO Category: Core Email Label: Which BO under menu is concerned PR available Solution: issue is being addressed Task Type: neither a bug or a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@matthieu-rolland @matks @prestonBot @hibatallahAouadni @M0rgan01 @MatShir @WahbiPS