Update egulias/email-validator to 4.0.1 and bump multiple doctrine deps

[M0rgan01]

Questions	Answers
Branch?	develop
Description?	Update egulias/email-validator to 4.0.1. This also requires updating: doctrine/dbal from 2.13.8 to 3.6.5 doctrine/deprecations from 0.5.3 to 1.1.1 doctrine/lexer from 1.2.3 to 2.1.0 doctrine/orm from 2.12.1 to 2.14.3
Type?	improvement
Category?	CO
BC breaks?	yes
Deprecations?	no
How to test?	CI and tests are green
UI tests	https://github.com/M0rgan01/ga.tests.ui.pr/actions/runs/6313332809
Fixed ticket?	#33445
Related PRs	productcomments/178 PrestaShop/ps_linklist#179
Sponsor company	-

Update details

• egulias/email-validator 4.0.1 want doctrine/lexer: ^2.0 || ^3.0
• doctrine/lexer 2.1.0 want doctrine/deprecations: ^1.0
  • doctrine/dbal 2.13.8 want doctrine/deprecations 0.5.3 -> should update doctrine/dbal to 2.13.9 OR 3.6.5
  • doctrine/orm 2.12.1 want doctrine/deprecations 0.5.3 -> should update to 2.14.3

Module prefix

We can no longer access module entities with a prefix like:

• $entityManager->find('MyModule:Entity', $id);
• $entityManager->createQuery('SELECT u FROM MyModule:Entity');

See doctrine/orm#8818

Exhaustive list of changes made following the DBAL doctrine update

• Statement->execute() now return Result instant of Statement
• Statement->closeCursor() is now Result->free()
• Doctrine\DBAL\DBALException is now Doctrine\DBAL\Exception
• QueryBuilder->setFirstResult() no longer allow null values (adding type)
• Connection->getWrappedConnection()->inTransaction() move in Connection->getNativeConnection()->inTransaction()
• Statement->execute() become:
  • Statement->executeQuery() for 'Select'
  • Statement->executeStatement() for 'Delete', 'Update' or 'Insert'
• Result->fetchAll() is now Result->fetchAllAssociative()
• Result->fetchAll(PDO::FETCH_COLUMN) is now Result->fetchFirstColumn()
• Result->fetch() is now Result->fetchAssociative()
• Result->fetch(PDO::FETCH_COLUMN) is now Result->fetchOne()

[M0rgan01]

The 'addEntityNamespace' function of doctrine ORM Configuration is deprecated and gives an error. See doctrine/orm#8818 and https://github.com/doctrine/DoctrineBundle/blob/29876aef5778af89c6bd18e88d0c5b9b8873dae2/DependencyInjection/Compiler/DoctrineOrmMappingsPass.php#L51

[jolelievre]

Hmm, so we can't define namespaces for modules' entities? Does it mean module also need to adapt how they use Doctrine entities? If so this will have to be documented in the BC breaks as well

[M0rgan01]

I don't understand how it worked before. I had an error Named parameter "id_product" does not have a bound value. after update, in https://github.com/doctrine/dbal/blob/195aad31e9596e4093d417583f98342b6f0ec986/src/ArrayParameters/Exception/MissingNamedParameter.php#L11

[jolelievre]

Yep the comma should only be added in the where, that was a mistake Maybe before Doctrine automatically understood it for some weird reason 😅

[hibatallahAouadni]

Hello @M0rgan01

Thanks for your PR 🚀
Unfortunately, the auto tests are broken caused by this issue:

Thanks @Progi1984 for the screenshot 🙏
Here's the link: https://github.com/hibatallahAouadni/testing_pr/actions/runs/6042014563
Please check and feedback.

Thanks!

[jolelievre]

I created a PR that modified the UI tests a little PrestaShop/ga.tests.ui.pr#47
The purpose is to add two things:

• export a MySQL dump on failure, here's the build currently running with this modify https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6107722840
• prevent the CLI installation in docker in sanity tests, since the test perform an install in browser as well Here's a build with this new modif as well https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6107798599

Edit: an error in the dump export so new run here https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6108846839

[jolelievre]

https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6322842472