Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.1.2 new style of product page has a critical problem on short description if not present the p tag #34347

Closed
2 tasks done
Tracked by #13891
maofree opened this issue Oct 19, 2023 · 8 comments · Fixed by #34600
Closed
2 tasks done
Tracked by #13891
Assignees
Labels
8.1.x Branch BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Major Severity: major bug > https://build.prestashop.com/news/severity-classification New Products Page Label: Which BO under menu is concerned Verified The issue has been reproduced

Comments

@maofree
Copy link

maofree commented Oct 19, 2023

Prerequisites

Describe the bug and add attachments

Hi
I've found a big problem on the new style of the product pages - admin side

it is present only on the short description

if in the ps_product_lang there is not the

tags to limit the short descriptions there is a javascript error which blocks the product page without giving the possibility to make changes

5
6

I got this error from a site of my customer that use csv import. so in the file there are no present html code and

to open and

to close thje descriptions

this problem is not present in the long description, if I set from phpmyadmin a text without p tags I can save from the product page and the p tags will be creates subsequently
the same should be done for the short description

is it possible to fix this problem on the next 8.1.3? I think is important and many sites use external imports

Expected behavior

No response

Steps to reproduce

  1. take a product to do the test and active the new style
  2. go to phpmyadmin into ps_product_lang
  3. remove

    and

    from the short description of a language of this product
  4. go to the product page, admin side
  5. try to do something and open the console log

PrestaShop version(s) where the bug happened

8.1.2

PHP version(s) where the bug happened

8.1

If your bug is related to a module, specify its name and its version

No response

Your company or customer's name goes here (if applicable).

No response

@maofree maofree added Bug Type: Bug New New issue not yet processed by QA labels Oct 19, 2023
@AureRita AureRita added Major Severity: major bug > https://build.prestashop.com/news/severity-classification BO Category: Back Office Ready Status: Issue is ready to be worked on Verified The issue has been reproduced 8.1.x Branch New Products Page Label: Which BO under menu is concerned and removed New New issue not yet processed by QA labels Oct 24, 2023
@AureRita
Copy link
Contributor

Hi @maofree

Thank you for your report, I tried to reproduce your issue as you can see :

Untitled_.Oct.24.2023.11_46.AM.webm

as you can see at the start I don't reproduce the issue, but after other test, I find the issue.

It's because you put a dot (.) on your short description as you can see :

Untitled_.Oct.24.2023.11_59.AM.webm

Because I reproduce the issue with PrestaShop version 8.1.2, I'll add this to the backlog so it can be fixed.

Please be aware that some issues might take a very long time to be resolved.

Thanks

@Hlavtox Hlavtox mentioned this issue Nov 3, 2023
2 tasks
@Hlavtox
Copy link
Contributor

Hlavtox commented Nov 10, 2023

@PrestaShop/prestashop-core-developers

Happens only only new product page, tinymce fields in other pages are working fine.

Probably something to do with "watching for changes". Is it even needed? Why we can't enable the button right away?

@RosaBenouamer
Copy link

Is the problem only on dot ?

@Hlavtox
Copy link
Contributor

Hlavtox commented Nov 13, 2023

@RosaBenouamer on all texts that do not start/contain html tags

@M0rgan01
Copy link
Contributor

PR: #34600

@nicosomb nicosomb linked a pull request Nov 17, 2023 that will close this issue
@WahbiPS WahbiPS closed this as completed Nov 20, 2023
@prestashop-issue-bot prestashop-issue-bot bot removed the Ready Status: Issue is ready to be worked on label Nov 20, 2023
@RosaBenouamer RosaBenouamer added the Fixed Resolution: issue closed because fixed label Nov 21, 2023
@gregoire-jianda gregoire-jianda mentioned this issue Dec 6, 2023
22 tasks
@Jenny-Glamorhair
Copy link

Ive done a fresh new install and this problem came up after 2 days. it was first working but stopped this morning. I found that contents added by csv import. its also not working with Description. the solution is to remove the content, paste into notepad to remove all tags, paste back and save. it works. for by system, the P tags wasnt the problem as I pasted in without tags and it saved. it just not working with csv tags. I had even typed out the tags and it didint work.

@florine2623
Copy link
Contributor

I can't reproduce your issue on PS 8.1.3.

I removed the p tag, and I could save the short description on the product page as expected.

Screen.Recording.2024-01-15.at.14.51.37.mov

@Hlavtox
Copy link
Contributor

Hlavtox commented Jan 15, 2024

@florine2623 Yeah it's fixed, don't worry. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.1.x Branch BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Major Severity: major bug > https://build.prestashop.com/news/severity-classification New Products Page Label: Which BO under menu is concerned Verified The issue has been reproduced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants