Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary Jquery selector in SerpApp. #34600

Merged
merged 1 commit into from Nov 17, 2023
Merged

Remove unnecessary Jquery selector in SerpApp. #34600

merged 1 commit into from Nov 17, 2023

Conversation

M0rgan01
Copy link
Contributor

@M0rgan01 M0rgan01 commented Nov 16, 2023 •
edited

Questions Answers
Branch? 8.1.x
Description? Remove unnecessary Jquery selector in SerpApp. This contains the content of the tag, which causes side effects (see associated ticket).
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? CI and tests UI are green
UI Tests https://github.com/M0rgan01/ga.tests.ui.pr/actions/runs/6901758350
Fixed issue or discussion? Fixes #34347
Related PRs -
Sponsor company -

@M0rgan01 M0rgan01 requested a review from a team as a code owner November 16, 2023 17:23
@prestonBot prestonBot added 8.1.x Branch Bug fix Type: Bug fix labels Nov 16, 2023
@PrestaShop PrestaShop deleted a comment from prestonBot Nov 16, 2023
@M0rgan01 M0rgan01 added this to the 8.1.3 milestone Nov 16, 2023
@M0rgan01 M0rgan01 mentioned this pull request Nov 17, 2023
Closed
2 tasks
@nicosomb nicosomb linked an issue Nov 17, 2023 that may be closed by this pull request
8.1.2 new style of product page has a critical problem on short description if not present the p tag #34347
Closed
2 tasks
Hlavtox
Hlavtox approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that it successfully fixes the issue with non-html content in the fields. :-)

I simulated the condition.

Snímek obrazovky 2023-11-17 151410

And page loads good with no errors.

Snímek obrazovky 2023-11-17 151430

@PrestaShop/qa-functional Putting QA check because auto tests are also OK. :-)

@Hlavtox Hlavtox added the QA ✔️ Status: check done, code approved label Nov 17, 2023
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Nov 17, 2023
@PrestaShop PrestaShop deleted a comment from prestashop-issue-bot bot Nov 17, 2023
@PrestaShop PrestaShop deleted a comment from prestashop-issue-bot bot Nov 17, 2023
@Hlavtox Hlavtox merged commit 19737c1 into PrestaShop:8.1.x Nov 17, 2023
38 checks passed
@nicosomb nicosomb removed the Waiting for QA Status: action required, waiting for test feedback label Nov 17, 2023
@matks matks mentioned this pull request Dec 6, 2023
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tleon tleon tleon approved these changes

@Hlavtox Hlavtox Hlavtox approved these changes

Assignees
No one assigned
Labels
8.1.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.3
Development

Successfully merging this pull request may close these issues.

8.1.2 new style of product page has a critical problem on short description if not present the p tag
6 participants
@M0rgan01 @tleon @Hlavtox @nicosomb @ps-jarvis @prestonBot