Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOOM-4432] Link widget module : does not work with multiple shops (multishop) #9795

Closed
prestonBot opened this issue Aug 22, 2018 · 16 comments · Fixed by PrestaShop/ps_linklist#114
Assignees
Labels
1.7.2.0 Affects versions 1.7.4.1 Affects versions 1.7.6.3 Affects versions 1.7.7.0 Affects versions Bug Type: Bug Fixed Resolution: issue closed because fixed Link widget Label: Which BO under menu is concerned Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Modules & Themes Component: Which BO section is concerned Multistore Label: Which BO under menu is concerned Must-have Kanban prioritization: issue must be included in next version Topwatchers Backlog prioritization: issue reported & followed by +6 people

Comments

@prestonBot
Copy link
Collaborator

prestonBot commented Aug 22, 2018

This issue has been migrated from the Forge. Read the original ticket here.

  • Reporter: malorie
  • Created at: Wed, 6 Dec 2017 15:15:20 +0100

This module doesn't work in multiple shops.

Only 1 shop is ok, the others ars the same links... It's impossible to have different links.


Describe the bug

When i check or uncheck content pages as "About us" or "Legal notice" from the Link Widget in a Shop scope (Store2 in this example).... it affect to all stores and always the same link pages are shown on footer for all stores.

imagen

Expected behavior

The pages checked in a specific store should show only in the own store.

imagen

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to Admin -> Link Widget -> Select a specific store scope.
  2. Change the checkbox options for some pages
  3. Go to frontend to a different store scope from step 1 and scoll down to see the footer.
  4. You see always the same link pages.

Additional information

  • PrestaShop version: 1.7.7.0
  • PHP version: N/A

Originally posted by @ruchus

@prestonBot prestonBot added 1.7.2.0 Affects versions 1.7.4.0 Affects versions 1.7.4.1 Affects versions Bug Type: Bug Link widget Label: Which BO under menu is concerned Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Modules & Themes Component: Which BO section is concerned Multistore Label: Which BO under menu is concerned Ready Status: Issue is ready to be worked on Topwatchers Backlog prioritization: issue reported & followed by +6 people labels Aug 22, 2018
@prestonBot
Copy link
Collaborator Author

This comment has been migrated from the Forge. Read the original comment here.

  • Author: salma.moakhar
  • Created at: Wed, 6 Dec 2017 15:41:48 +0100

Hi Malorie,

I manage to reproduce the issue with the last version : 1.7.2.4.
We will see how to fix it.

Thanks & best regards, Salma

@prestonBot
Copy link
Collaborator Author

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: marion_francois
  • Created at: Thu, 7 Dec 2017 11:14:43 +0100

When a new block is added, the merchant should be able to choose to which shop(s) the block will be associated thanks to the “shop association block” component.

This way the block will be displayed in FO only for the selected shop(s)

@prestonBot
Copy link
Collaborator Author

This comment has been migrated from the Forge. Read the original comment here.

  • Author: habros
  • Created at: Sat, 6 Jan 2018 07:28:08 +0100

Is there any workaround for this issue? Or alternative solution? Can't really do multistore without it.

@prestonBot
Copy link
Collaborator Author

This comment has been migrated from the Forge. Read the original comment here.

  • Author: reho
  • Created at: Sun, 7 Jan 2018 21:18:11 +0100

Dave, I did some modifications to make work the public part of it. Look at the comments section of the duplicate issue (BOOM-4269)

You can edit the pages in a database manager.

@marionf
Copy link
Contributor

marionf commented Nov 13, 2018

The issue when I enable multistore, whatever if I select a specific shop or "all shop", I have as many links as shops and as many "Content pages" is solved by PrestaShop/ps_linklist#48

It stays this issue with linkwidget when multistore is enabled:
the merchant should be able to choose to which shop(s) the block will be associated thanks to the “shop association block” component.

@Klemart3D
Copy link
Contributor

Klemart3D commented Mar 7, 2019

Reproduced on PS v1.7.5.0 + 1.7.5.1 too (with ps_linklist v3.0.2)

@unreviewed
Copy link

This is happening PS v1.7.5.1 - Problem seems to be only related to opening the front end shops using top right hand link.

@paulydev
Copy link

I have this same issue in 1.7.6.1. Is there still no fix for it?

@jcaubame
Copy link

Hi, I'm using prestashop 1.7.2.4 and I'm searching for a fix for it to. It's been a while this issue is opened and it's strange that no fix exist. Nobody use multistore? Or nobody use ps_linklist? Or someone have fix it and don't share it? I'will work on that fix and keep you informed if it's working.

@alex4102
Copy link
Contributor

Up

@Bugfunder
Copy link

Bugfunder commented Apr 4, 2020

It is probably not fixed yet because it is quite easy to fix the front part (as mentioned earlier):

diff modules/ps_linklist/src/LegacyLinkBlockRepository.php modules/ps_linklist/src/LegacyLinkBlockRepository.php.orig 
74,75c74
<                     JOIN {$this->db_prefix}link_block_shop lbs on cb.`id_link_block`=lbs.`id_link_block`
<                     WHERE `id_hook` = $id_hook and `id_shop`={$this->shop->id}
---
>                     WHERE `id_hook` = $id_hook

The rest can be done via DB and the admin interface.

@alex4102
Copy link
Contributor

alex4102 commented Apr 6, 2020

It is probably not fixed yet because it is quite easy to fix the front part (as mentioned earlier):

diff modules/ps_linklist/src/LegacyLinkBlockRepository.php modules/ps_linklist/src/LegacyLinkBlockRepository.php.orig 
74,75c74
<                     JOIN {$this->db_prefix}link_block_shop lbs on cb.`id_link_block`=lbs.`id_link_block`
<                     WHERE `id_hook` = $id_hook and `id_shop`={$this->shop->id}
---
>                     WHERE `id_hook` = $id_hook

The rest can be done via DB and the admin interface.

Hello, this is just for frontend, we need fix because lot of people use the back-office.

@Bugfunder
Copy link

I agree absolutely that this should be fixed officially. I just wanted to post a fix for the people who can not/will not wait till that happens. Those can still use the back office (admin interface) to create link lists, and then specify for which shops they are in the link_block_shop table in the DB.

@marionf marionf added the Must-have Kanban prioritization: issue must be included in next version label Oct 28, 2020
@hibatallahAouadni hibatallahAouadni added 1.7.7.0 Affects versions and removed 1.7.4.0 Affects versions labels Mar 17, 2021
@khouloudbelguith
Copy link
Contributor

Hi!

About this issue: #9795, the issue became a normal behavior as discussed with @marionf
Actions in the listings (grids): Edit action

User acceptance test Given I am a merchant in a multistore context, when I am editing an element then I want the changes I made to be applied to all stores with which the element is associated.

I close this issue, this PR: PrestaShop/ps_linklist#114 is QA ✔️

Thank you!

@prestashop-issue-bot prestashop-issue-bot bot removed the Ready Status: Issue is ready to be worked on label Apr 26, 2021
@khouloudbelguith khouloudbelguith added the Fixed Resolution: issue closed because fixed label Apr 26, 2021
@matks
Copy link
Contributor

matks commented Apr 26, 2021

Pull Request PrestaShop/ps_linklist#114 has been merged. The fix for this issue is expected to be delivered with v5.0.0 of Linklist module.

@matks matks changed the title [BOOM-4432] Link widget : doesn't work in multiple shops [BOOM-4432] Link widget module : does not work with multiple shops (multishop) Jun 1, 2021
@raganas
Copy link

raganas commented Jul 7, 2023

I still have issue with linklist v5.0.5 in multishop store v1.7.8.8.
when I add link for specific store it is not accessible (visible) in module configuration page. so cannot edit or delete it. if I add link for all stores I can view and edit it or delete it. links are accessible on frontend, but i cannot view or modify it in backend for specific stores.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.2.0 Affects versions 1.7.4.1 Affects versions 1.7.6.3 Affects versions 1.7.7.0 Affects versions Bug Type: Bug Fixed Resolution: issue closed because fixed Link widget Label: Which BO under menu is concerned Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Modules & Themes Component: Which BO section is concerned Multistore Label: Which BO under menu is concerned Must-have Kanban prioritization: issue must be included in next version Topwatchers Backlog prioritization: issue reported & followed by +6 people
Projects
None yet
Development

Successfully merging a pull request may close this issue.