[BOOM-3165] Price calculations ; product combination HT / TTC, I input 260 impact on price and 259.999999 is saved

[prestonBot]

This issue has been migrated from the Forge. Read the original ticket here.

• Reporter: antoine_pathie
• Created at: Thu, 1 Jun 2017 12:17:08 +0200

On my development site and a local fresh new install it's impossible to save a price impact with correct round.

For example, after entering 260 in "Impact on price (tax incl.) (step1.jpg) and clicking on "back to product" (backtoproduct.jpg) then click again on the combination the price change to "259.999999" (backtocombination.jpg). On the front-office the price is incorrect.

Moreover the final price is not calculated on the recap of all combinations.(backtoproduct.jpg)

• How to reproduce the issue ?

Edited by Khouloud

Reported here: #28482 (review)

1. Create a tax rule = 23%
2. Go to BO > Catalog > Product V2
3. Create a product with combinations > In the pricing tab: tax rule = 23% Retail price tax secluded = 10 / Retail price tax included = 12.3 / ecotax = 0 )
4. Generate a combination & edit it > impact on price tax included = 12 and click outside
5. See error: it will be converted to 12.000001

Products.experimental.PrestaShop.mp4

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: antoine_pathie
• Created at: Tue, 13 Jun 2017 08:44:24 +0200

Is this bug will be corrected in the next release ? It's kind of critical, I'm waiting this issue to be solved to put my client website online as I can't edit correct prices for the products with combinations.

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: vincentbz
• Created at: Tue, 13 Jun 2017 11:13:35 +0200

Hi guys,

Are you working on the 1.7.1.1 version ? I'm trying to reproduce this issue. I currently can't on these fields, I can reproduce it on the unit price only.

Thanks

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: antoine_pathie
• Created at: Tue, 13 Jun 2017 15:11:53 +0200

Yes it is on a 1.7.1.1 on a both a fresh new install and my shop in development

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: antoine_pathie
• Created at: Tue, 13 Jun 2017 15:26:10 +0200

• Just installed 1.7.1.2
• Created a new product.
• Product price set to 0
• Create two combination with Size S and M
• First combination : impact on price TTC set to 59
• Next combination : impact on price set to 160
• Back to product
• Edit first combination
• Impact on price TTC is modified to 58.999999 for the first combination
• Impact on price TTC is not modified for the second combination (160)

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: antoine_pathie
• Created at: Mon, 26 Jun 2017 13:50:43 +0200

Did you manage to reproduce the issue ?
Another way to reproduce the issue.

• Set price impact HT to 216.666667 (so the TTC is 260)
• Save and go back to the catalog
• Edit the product again
• Combinations tab : Prices seem OK
• Save and go back to the catalog
• Edit the product again
• Price impact HT is now 216,000000 (so the TTC is 259.2)

Thank you

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: antoine_pathie
• Created at: Mon, 3 Jul 2017 08:20:53 +0200

Hi,
Shouldn't it be categorized as critical issue not to be able to put correct prices on an ecommerce solution ?
I can't ask my client to check rounding and change combination price each time he wants to modify something else on the product page.

Thank you

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: antoine_pathie
• Created at: Wed, 12 Jul 2017 18:55:30 +0200

Hi,
It seems that the issue only occurs in french because the decimal separator is a comma.
When the page load sometimes the value is replaced by a dot and sometime a comma.... It its the same for the weight impact.

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: vincentbz
• Created at: Tue, 18 Jul 2017 10:47:54 +0200

Hi Antoine Pathie,

You're right, it's related to comma/dot separator, according to some countries.
We've fixed it in 1.7.2.0 but it can also occur in some rare cases. And these cases will be fixed in 1.7.2.1

Thanks

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: pablo.borowicz
• Created at: Fri, 21 Jul 2017 15:37:44 +0200

Vincent Beudez On sait quels sont ces cas rares ?

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: marion_francois
• Created at: Thu, 23 Nov 2017 15:01:47 +0100

Je peux reproduire le problème, regardez la vidéo attachée

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: vincentbz
• Created at: Fri, 24 Nov 2017 16:12:27 +0100

C'est le même souci sur pas mal de champs, cf BOOM-1255

[matthieu-rolland]

I assigned this issue to myself, as explained here: #20144 (comment)

[matthieu-rolland]

This issue might be fixed by PR #23929

[elboletaire]

I'm still trying to understand how are you proceeding with the project, and I do have issues opened with proposed changes since weeks ago waiting for a "yes" or "no, you can't do it". So I guess I'll continue waiting...

Almost one year later I'm still waiting for issues to be answered and merged. I'm tired of how this project moves forward, so I'll close all my issues and PRs. Feel free to do whatever you want with them.

[matks]

I'm still trying to understand how are you proceeding with the project, and I do have issues opened with proposed changes since weeks ago waiting for a "yes" or "no, you can't do it". So I guess I'll continue waiting...

Almost one year later I'm still waiting for issues to be answered and merged. I'm tired of how this project moves forward, so I'll close all my issues and PRs. Feel free to do whatever you want with them.

Hi @elboletaire today I found a tweet that unfortunately explains very well what happened. It was written by Adam Wathan, creator of Tailwind

https://twitter.com/adamwathan/status/1381275398646927362?s=19

"One of the most stressful parts of product development (especially open source) is when people are frustrated you haven’t made the improvement they want and automatically attribute it to complacency or ignoring the community instead of just being completely buried in work to do.

If something important takes two years to get worked on, it’s usually because there are two years worth of other fires to put out and work that’s necessary for pure survival. Things taking a long time is more stressful for me than it is for you, I promise. We’re on the same side."

Just like Adam Wathan, we're sorry 😭 , its not we dont care it's rather we're buried in work to do and the flow of incoming PRs and issues never ends.

[matks]

This issue seems similar to #12078

[marionf]

@matks it's the same issue but not the same field.
Here it's about the impact on price field in the combinations tab for a product with combinations
While #12078 is about the price field in basic settings & pricing tab for a standard product