New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add form handler for Translations settings forms #10165
Merged
mickaelandrieu
merged 3 commits into
PrestaShop:develop
from
rokaszygmantas:translations_form_handler
Aug 28, 2018
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100 changes: 100 additions & 0 deletions
100
...pBundle/Form/Admin/Improve/International/Translations/TranslationsSettingsFormHandler.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| <?php | ||
| /** | ||
| * 2007-2018 PrestaShop | ||
| * | ||
| * NOTICE OF LICENSE | ||
| * | ||
| * This source file is subject to the Open Software License (OSL 3.0) | ||
| * that is bundled with this package in the file LICENSE.txt. | ||
| * It is also available through the world-wide-web at this URL: | ||
| * https://opensource.org/licenses/OSL-3.0 | ||
| * If you did not receive a copy of the license and are unable to | ||
| * obtain it through the world-wide-web, please send an email | ||
| * to license@prestashop.com so we can send you a copy immediately. | ||
| * | ||
| * DISCLAIMER | ||
| * | ||
| * Do not edit or add to this file if you wish to upgrade PrestaShop to newer | ||
| * versions in the future. If you wish to customize PrestaShop for your | ||
| * needs please refer to http://www.prestashop.com for more information. | ||
| * | ||
| * @author PrestaShop SA <contact@prestashop.com> | ||
| * @copyright 2007-2018 PrestaShop SA | ||
| * @license https://opensource.org/licenses/OSL-3.0 Open Software License (OSL 3.0) | ||
| * International Registered Trademark & Property of PrestaShop SA | ||
| */ | ||
|
|
||
| namespace PrestaShopBundle\Form\Admin\Improve\International\Translations; | ||
|
|
||
| use PrestaShop\PrestaShop\Core\Form\FormHandlerInterface; | ||
| use PrestaShop\PrestaShop\Core\Hook\HookDispatcherInterface; | ||
| use Symfony\Component\Form\FormBuilderInterface; | ||
|
|
||
| final class TranslationsSettingsFormHandler implements FormHandlerInterface | ||
| { | ||
| /** | ||
| * @var FormBuilderInterface the form builder | ||
| */ | ||
| protected $formBuilder; | ||
|
|
||
| /** | ||
| * @var HookDispatcherInterface the event dispatcher | ||
| */ | ||
| protected $hookDispatcher; | ||
|
|
||
| /** | ||
| * @var string the hook name to be dispatched | ||
| */ | ||
| protected $hookName; | ||
|
|
||
| /** | ||
| * @var array the list of Form Types | ||
| */ | ||
| protected $formTypes; | ||
|
|
||
| /** | ||
| * @param FormBuilderInterface $formBuilder | ||
| * @param HookDispatcherInterface $hookDispatcher | ||
| * @param array $formTypes | ||
| * @param string $hookName | ||
| */ | ||
| public function __construct( | ||
| FormBuilderInterface $formBuilder, | ||
| HookDispatcherInterface $hookDispatcher, | ||
| array $formTypes, | ||
| $hookName | ||
| ) { | ||
| $this->formBuilder = $formBuilder; | ||
| $this->hookDispatcher = $hookDispatcher; | ||
| $this->formTypes = $formTypes; | ||
| $this->hookName = $hookName; | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function getForm() | ||
| { | ||
| foreach ($this->formTypes as $formName => $formType) { | ||
| $this->formBuilder->add($formName, $formType); | ||
| } | ||
|
|
||
| $this->hookDispatcher->dispatchWithParameters( | ||
| "action{$this->hookName}Form", | ||
| [ | ||
| 'form_builder' => $this->formBuilder, | ||
| ] | ||
| ); | ||
|
|
||
| return $this->formBuilder->getForm(); | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function save(array $data) | ||
| { | ||
| // Translations forms do not save data | ||
| return []; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw @mickaelandrieu this proves the point that you wanted to test, that passing hook params by reference is not needed when they are objects :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok 👍 good to know, I'll clean the others object calls
edit: you only have to use
./vendor/bin/php-cs-fixer fixand push your commit to fix the build: we now check our coding styles :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do the cs fix :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed