Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle bool return from query validator #10424

Closed
wants to merge 4 commits into from
Closed

Handle bool return from query validator #10424

wants to merge 4 commits into from

Conversation

matks
Copy link
Contributor

@matks matks commented Sep 13, 2018 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Avoid SqlQueryValidator crash (fatal error) if SQL Parser returns a boolean error instead of an array
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Follow #10316 behavior and see that the "symfony error" page does not show anymore, instead user has a nice error message and can keep working.

This eases behavior of issue #10316.
It does not fix it but at least user has an error message instead of a 500 error page.

This change is Reviewable

@prestonBot prestonBot added develop Branch Improvement Type: Improvement Waiting for wording Status: action required, waiting for wording labels Sep 13, 2018
@matks matks mentioned this pull request Sep 13, 2018
Closed
@PierreRambaud
Copy link
Contributor

@matks Look like you include your stock location branch in this PR :)

@matks
Copy link
Contributor Author

matks commented Sep 13, 2018

@PierreRambaud 😭

@matks
Copy link
Contributor Author

matks commented Sep 13, 2018

Bad PR, replaced by #10426

@matks matks closed this Sep 13, 2018
@matks matks deleted the handle-bool-return-from-query-validator branch September 13, 2018 15:54
@matks matks removed Improvement Type: Improvement develop Branch Waiting for wording Status: action required, waiting for wording labels Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matks @PierreRambaud @prestonBot