New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #10433 : Update lastName and firstName max size #10438

Merged
merged 1 commit into from Sep 16, 2018

Conversation

Projects
None yet
6 participants
@FranckRIBEIRO
Contributor

FranckRIBEIRO commented Sep 14, 2018

Questions Answers
Branch? develop
Description? update first and lastName field in address form to match those in customer form
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? #10433
How to test? create customer with name longer than 32car and add an address with the name auto filled

This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Sep 14, 2018

Collaborator

Hello @FranckRIBEIRO!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Sep 14, 2018

Hello @FranckRIBEIRO!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@khouloudbelguith

This comment has been minimized.

Show comment
Hide comment
@khouloudbelguith
Contributor

khouloudbelguith commented Sep 14, 2018

Fixes #10433

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Sep 14, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Sep 14, 2018

@PrestaShop PrestaShop deleted a comment from prestonBot Sep 16, 2018

@mickaelandrieu mickaelandrieu merged commit a0375da into PrestaShop:develop Sep 16, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu
Contributor

mickaelandrieu commented Sep 16, 2018

Thanks @FranckRIBEIRO !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment