Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Issue #10433 : Update lastName and firstName max size #10438

Merged
merged 1 commit into from Sep 16, 2018
Merged

Fix for Issue #10433 : Update lastName and firstName max size #10438

merged 1 commit into from Sep 16, 2018

Conversation

FranckRIBEIRO
Copy link
Contributor

@FranckRIBEIRO FranckRIBEIRO commented Sep 14, 2018 •
edited by jolelievre

Questions Answers
Branch? develop
Description? update first and lastName field in address form to match those in customer form
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? #10433
How to test? create customer with name longer than 32car and add an address with the name auto filled

This change is Reviewable

@prestonBot
Copy link
Collaborator

Hello @FranckRIBEIRO!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@khouloudbelguith
Copy link
Contributor

Fixes #10433

@PierreRambaud PierreRambaud added develop Branch Bug Type: Bug labels Sep 14, 2018
@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Sep 14, 2018
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Sep 14, 2018
@ntiepresta ntiepresta added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Sep 14, 2018
@MathiasReker MathiasReker mentioned this pull request Sep 15, 2018
Merged
@PrestaShop PrestaShop deleted a comment from prestonBot Sep 16, 2018
@mickaelandrieu mickaelandrieu merged commit a0375da into PrestaShop:develop Sep 16, 2018
@mickaelandrieu
Copy link
Contributor

Thanks @FranckRIBEIRO !

@khouloudbelguith khouloudbelguith mentioned this pull request Sep 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@FranckRIBEIRO @prestonBot @khouloudbelguith @mickaelandrieu @PierreRambaud @ntiepresta