Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent CS Fixer from adding a trailing dot to the first paragraph of phpdoc #11068

Merged
merged 1 commit into from Oct 19, 2018
Merged

Prevent CS Fixer from adding a trailing dot to the first paragraph of phpdoc #11068

merged 1 commit into from Oct 19, 2018

Conversation

eternoendless
Copy link
Member

@eternoendless eternoendless commented Oct 18, 2018 •
edited

Questions Answers
Branch? 1.7.5.x
Description? CS Fixer adds a trailing dot to the first paragraph of PHPdoc, regardless of what it is. Not only the value of this is pretty limited, but it also changes our class header to add a dot.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? No test needed

This change is Reviewable

@eternoendless eternoendless added this to the 1.7.5.0 milestone Oct 18, 2018
@prestonBot prestonBot added 1.7.5.x Branch Improvement Type: Improvement labels Oct 18, 2018
@eternoendless eternoendless merged commit 2882c63 into PrestaShop:1.7.5.x Oct 19, 2018
@eternoendless eternoendless deleted the cs-rules branch August 14, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees
No one assigned
Labels
1.7.5.x Branch Improvement Type: Improvement
Projects
None yet
Milestone
1.7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eternoendless @PierreRambaud @prestonBot