New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent CS Fixer from adding a trailing dot to the first paragraph of phpdoc #11068

Merged
merged 1 commit into from Oct 19, 2018

Conversation

Projects
None yet
3 participants
@eternoendless
Member

eternoendless commented Oct 18, 2018

Questions Answers
Branch? 1.7.5.x
Description? CS Fixer adds a trailing dot to the first paragraph of PHPdoc, regardless of what it is. Not only the value of this is pretty limited, but it also changes our class header to add a dot.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? No test needed

This change is Reviewable

@eternoendless eternoendless added this to the 1.7.5.0 milestone Oct 18, 2018

@eternoendless eternoendless merged commit 2882c63 into PrestaShop:1.7.5.x Oct 19, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment