Add LegacyContext::getLegacyAdminLink #11309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded in some edge cases
matks
reviewed
Nov 9, 2018
| @@ -125,7 +125,8 @@ public function importAction(Request $request) | |||
| } | |||
|
|
|||
| $formData = $form->getData(); | |||
| if (!$errors = $formHandler->save($formData)) { | |||
| $errors = $formHandler->save($formData); | |||
| * | ||
| * @return string | ||
| */ | ||
| public function getLegacyAdminLink($controller, $withToken = true, $extraParams = array()) |
There was a problem hiding this comment.
Are you sure this should go into LegacyContext class, rather than in Link core class ?
As it is inspired by https://github.com/PrestaShop/PrestaShop/blob/develop/classes/Link.php#L807
There was a problem hiding this comment.
good idea, but then it should be in both no?
Quetzacoalt91
approved these changes
Nov 15, 2018
Quetzacoalt91
added
the
Waiting for QA
marionf
added
QA ✔️
|
Thank you @jolelievre |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is