Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shop name in the subject of mail #11564

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Fix shop name in the subject of mail #11564

merged 1 commit into from
Dec 3, 2018

Conversation

khouloudbelguith
Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Nov 29, 2018 •
edited by eternoendless

Questions Answers
Branch? develop
Description? The name of the shop is incorrect in the subject of the email "Product out of stock" or "Welcome", "Order confirmation",.. when multishop is enabled.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11081
How to test? 1- Install the module ps_emailalert => 2- Enable the option out of stock => 3- Enable multishop ( share quantities is disabled ) => 4- Create a second shop with the name "Shop 2" => 5-Create a product "Prod" exist only in the Shop 2 => 6- Set the quantity of "Prod" to -2=> 7- An email is sent to the administrator to alert the out of stock of the product "PROD"

This change is Reviewable

@prestonBot prestonBot added develop Branch Bug Type: Bug labels Nov 29, 2018
@Quetzacoalt91 Quetzacoalt91 added the Waiting for QA Status: action required, waiting for test feedback label Nov 29, 2018
@ntiepresta ntiepresta self-assigned this Nov 29, 2018
@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Nov 29, 2018
@ntiepresta ntiepresta added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 30, 2018
@ntiepresta ntiepresta removed their assignment Nov 30, 2018
@Quetzacoalt91 Quetzacoalt91 merged commit a0af460 into PrestaShop:develop Dec 3, 2018
@Quetzacoalt91
Copy link
Member

Thank you @khouloudbelguith & @ntiepresta

@eternoendless eternoendless changed the title Fix Name of shop in the subject of mail Fix shop name in the subject of mail Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.6.0
Development

Successfully merging this pull request may close these issues.

Name of shop is wrong in the subjet of the email "Product out of stock" - Multishop -
5 participants
@khouloudbelguith @Quetzacoalt91 @PierreRambaud @prestonBot @ntiepresta