Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gif support to webpack.config.js #11576

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

adviva
Copy link
Contributor

@adviva adviva commented Nov 30, 2018

Questions Answers
Branch? develop
Description? When compiling the assets it will trigger errors if using .gif files.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Use a .gif file inside img theme folder.

This change is Reviewable

@prestonBot
Copy link
Collaborator

Hello @adviva!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@Quetzacoalt91
Copy link
Member

Hi @adviva,

Thanks, this change makes sens regarding your error. But is it needed to include in in the core?
We do not provide gif files with the source code, and theme developers are recommended to create a new child theme from classic instead of modifying it directly. By doing so, they can reuse a parent theme (here, classic) without being tied to it.

In consequence, if you have gif files in your own theme, you should use your own webpack configuration.

@adviva
Copy link
Contributor Author

adviva commented Nov 30, 2018

So you are assuming any node_module package required in package.json won't use .gif?

We suggest this as core implementation to avoid annoying errors from the first classic override. (Eg. by installing something like fancybox etc...).

@PierreRambaud
Copy link
Contributor

Agreed with @adviva wait for @eternoendless feedback, he is the Webpack master 😁

Copy link
Member

@eternoendless eternoendless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eternoendless eternoendless added this to the 1.7.6.0 milestone Dec 4, 2018
@PierreRambaud PierreRambaud merged commit 0829e7b into PrestaShop:develop Dec 4, 2018
@PierreRambaud
Copy link
Contributor

Thanks @adviva

@eternoendless eternoendless changed the title Added .gif support to webpack.config.js Add .gif support to webpack.config.js Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: Bug develop Branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants