Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated functions #11579

Merged
merged 1 commit into from Dec 3, 2018
Merged

Remove deprecated functions #11579

merged 1 commit into from Dec 3, 2018

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented Nov 30, 2018 •
edited by eternoendless

Questions Answers
Branch? 1.7.5.x
Description? Remove each function calls, and use the appropriate variant for idn_to_ascii
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11553
How to test?

This change is Reviewable

@jolelievre jolelievre added this to the 1.7.5.0 milestone Nov 30, 2018
@prestonBot prestonBot added 1.7.5.x Branch Bug Type: Bug labels Nov 30, 2018
@Quetzacoalt91 Quetzacoalt91 added the Waiting for QA Status: action required, waiting for test feedback label Dec 3, 2018
@marionf marionf self-assigned this Dec 3, 2018
@marionf marionf added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Dec 3, 2018
@PierreRambaud PierreRambaud merged commit 4b776ce into PrestaShop:1.7.5.x Dec 3, 2018
@PierreRambaud
Copy link
Contributor

Thanks @jolelievre

@khouloudbelguith khouloudbelguith mentioned this pull request Dec 11, 2018
Closed
@rdy4ever rdy4ever mentioned this pull request Dec 31, 2018
Closed
@rdy4ever
Copy link
Contributor

rdy4ever commented Dec 31, 2018 •
edited

Hi there. This PR broke e-mail sending for some PHP servers running ICU < 4.6. See this issue: #11933
I think you should revert the changes in Mail.php.

@rdy4ever rdy4ever mentioned this pull request Jan 1, 2019
Merged
@jolelievre
Copy link
Contributor Author

Hi @rdy4ever
Do you think your PR #11995 fix this problem?

@rdy4ever
Copy link
Contributor

rdy4ever commented Jan 3, 2019

Hi @jolelievre
Yeap, it will be sorted out once #11995 will be merged.

@jolelievre
Copy link
Contributor Author

Great, thank you!

@jolelievre jolelievre deleted the remove-deprecations branch July 12, 2019 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud left review comments

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

Assignees

@marionf marionf

Labels
1.7.5.x Branch Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jolelievre @PierreRambaud @rdy4ever @Quetzacoalt91 @marionf @prestonBot