Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless space #11607

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Remove useless space #11607

merged 1 commit into from
Dec 4, 2018

Conversation

MathiasReker
Copy link
Contributor

@MathiasReker MathiasReker commented Dec 4, 2018 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Remove useless space in elseif
Type? improvement
Category? FO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? no
How to test? /

This change is Reviewable

@MathiasReker
Copy link
Contributor Author

After reading this: #11605 I scanned every .*tpl file for this issue.

@Quetzacoalt91
Copy link
Member

No need of QA on this one.

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Dec 4, 2018
@MathiasReker
Copy link
Contributor Author

Same issue for this path, but it should be fixed in the module:

modules\ps_themecusto\views\templates\admin\controllers\configuration\elem\module_actions.tpl
Line 64.

@MathiasReker
Copy link
Contributor Author

Nice catch @SebBareyre (#11605)

@Quetzacoalt91 Quetzacoalt91 merged commit 87f5270 into PrestaShop:develop Dec 4, 2018
@Quetzacoalt91
Copy link
Member

Thank you @MathiasReker

This was referenced Mar 15, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Milestone
1.7.6.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MathiasReker @Quetzacoalt91 @PierreRambaud @prestonBot