New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of protocol #11678

Merged
merged 3 commits into from Dec 10, 2018

Conversation

Projects
None yet
4 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 9, 2018

Questions Answers
Branch? develop
Description? Protocol should not be hardcoded.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? /

This change is Reviewable

MathiasReker added some commits Dec 9, 2018

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 10, 2018

Hi @MathiasReker,

how can we test this? I'm pretty sure it fixes a bug on shops powered by HTTPS but I'd like a reproducible test case so the QA team can validate it.

Mickaël

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 10, 2018

@mickaelandrieu I agree with you. Sorry, this was done from a theocratic point of view. I can not add a reproduce case for this. I am not sure exactly where to check this. It should be image path of some PDF stuff and some cronjobs. I am not 100% sure.

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 10, 2018

I'll ask another approval from @PrestaShop/prestashop-core-developers then 👍

@mickaelandrieu mickaelandrieu merged commit 6ef4baf into PrestaShop:develop Dec 10, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Dec 10, 2018

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 10, 2018

Thanks everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment