Fix use of protocol #11678
Merged
Fix use of protocol #11678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelandrieu
approved these changes
Dec 10, 2018
|
Hi @MathiasReker, how can we test this? I'm pretty sure it fixes a bug on shops powered by HTTPS but I'd like a reproducible test case so the QA team can validate it. Mickaël |
mickaelandrieu
added
the
Waiting for author
|
@mickaelandrieu I agree with you. Sorry, this was done from a theocratic point of view. I can not add a reproduce case for this. I am not sure exactly where to check this. It should be image path of some PDF stuff and some cronjobs. I am not 100% sure. |
|
I'll ask another approval from @PrestaShop/prestashop-core-developers then 👍 |
PierreRambaud
approved these changes
Dec 10, 2018
PierreRambaud
removed
the
Waiting for author
|
Thanks everyone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is