New optional feature - display out of stock products last #12441

gadnis · 2019-02-05T21:14:29Z

Questions	Answers
Branch?	develop
Description?	This PR adds a button in BO-> Shop Parameters -> Product Settings -> Pagination TAB, an option to display out of stock products last. If this feature enabled, than products goes in this order: 1. inStock, 2. OutOfStock & Available for order, 3. OutOfStock. Affected pages: category, best-sales, new-products, price-drop. It doesn't rearrange products if FO user sorts by: name or sales, cause it would be not logical. A lot of people has thousands of products in database and thousands of them is with quantity 0 but allowed to order. Before this feature, these "available to order" products went to the end of product list, with this feature it will go after the "available" products and out-of-stock products will be the last products.
Type?	new feature
Category?	FO
BC breaks?	no
Deprecations?	no
Fixed ticket?	"Fixes #9956". Or atleast one issue mentioned in comments.
How to test?	Turn off module: ps_facetedsearch (cause it overrides native functions for category pages). Go to: BO-> Shop Parameters -> Product Settings -> Pagination TAB. Switch "Display out-of-stock products last" to ON. Go to FO pages: any category, new-products, prices-drop, best-sales. Choose to sort by price, data added. You will see products sorted in the chunks: 1. inStock, 2. OutOfStock & Available for order, 3. OutOfStock.

Here is some pictures to help you understand what PR does:

BO: feature switch added:

FO: sort by Price examples:
In category pages:

In best-sales page:

In prices-drop page:

In new-product page:

Sort by Date added in new-product page:

This change is

When user adjust quantity in cart summary and wanted quantity is more than 'in-stock', than error notification shown, but with this improvement user knows maximum product quantity he can buy.

…rop, category pages, more to come

…ducts,product-sales,prices-drop

prestonBot · 2019-02-05T21:14:31Z

Hello @gadnis!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

matks · 2019-02-06T09:18:52Z

@colinegin This is a new feature, what do you think 😉 ?

LouiseBonnard · 2019-04-15T14:44:39Z

...sources/views/Admin/Configure/ShopParameters/Blocks/product_preferences_pagination.html.twig

@@ -47,6 +47,11 @@
                    {{ form_errors(paginationForm.default_order_way) }}
                    {{ form_widget(paginationForm.default_order_way) }}
                </div>
+                <div class="form-group">
+                    {{ ps.label_with_help(('Display out-of-stock products last'|trans), ('If enabled, products will be in this order: 1. in-stock, 2. available for order but quantity is 0, 3. out-of-stock. This does not apply when ordering by name & sales'|trans({}, 'Admin.Shopparameters.Help'))) }}


Hello, can you explain the "ordering by name & sales" please? Also, I would write If enabled, products will be displayed in this order: 1. in-stock, 2. available for order but quantity is 0, 3. out-of-stock. Note that it does not apply when ordering by name or sales. instead, what do you think?

marionf · 2019-08-01T08:46:49Z

Hello @gadnis

In BO > Shop parameters > Products settings, you can already choose to filter by quantity by default

This way, when your customer arrives on a category page, "Relevance" is selected and your products are sorted by quantity.

The problem is that this option only takes into account the quantity and not if out of stock products can be ordered or not.

So, we would like to take this into account when quantity is selected as default order by.
Without adding a new switch option

What dou think about that ?

gadnis · 2019-08-01T10:05:02Z

Hi @marionf ! It's kind of good idea but not really.. If people would choose to order by name, I understand that they want to see product in A-Z or Z-A order. But when day choose to order by price, they aspect to see lets say cheapest products first and hope that the seller has those products in stock, cause why else order by price.. unless to spy or investigate product prices, which is not that offen the case to order by price. I Would add a switch (ON, OFF option) to show out-of-stock products last.

marionf · 2019-08-02T08:23:38Z

Thank you for your answer @gadnis

I would like to test your PR and maybe suggest some improvements but there are some conflicting files and this generates errors
Could you please resolve conflicts ?

gadnis · 2019-08-02T08:29:15Z

Ok, @marionf, I will try to do that in the next week ;)

Adding switch to enable or disable the feature

Adding SwitchType to a Form. To be able switch off|on this feature

Adding configuration field 'display_out_of_stock_last'. It will be used to either enable or disable the feature

This one is not related to the feature. I'm not sure why it is in this PR. But it is useful.

Adding two methods: orderByOOSP and sqlOrderByOOSP There is All "facets" where we allow to sort out-of-stock last in method sqlOrderByOOSP And method orderByOOSP helps to do that later

changes marked with comment: ORDER BY out-of-stock products last

Allowing order products as described in PR Changes marked with comment: ORDER BY out-of-stock products last

gadnis

Code is now compatible with PS 1.7.6.2

…-last

gadnis · 2019-12-04T18:31:20Z

Thank you for your answer @gadnis

I would like to test your PR and maybe suggest some improvements but there are some conflicting files and this generates errors
Could you please resolve conflicts ?

Hi, @marionf , finally I updated our shop to the latest, and now I had to put back my code there. So I change the code in this PR also. Please review and merge it 😁

Now I will go to find out how to do the same feature on ps_facetedsearch module, cause it was refactored and my code is no fit in there...

LouiseBonnard · 2019-12-05T14:23:41Z

...sources/views/Admin/Configure/ShopParameters/Blocks/product_preferences_pagination.html.twig

@@ -55,7 +55,13 @@
            {{ form_widget(paginationForm.default_order_way) }}
          </div>
        </div>
-
+        <div class="form-group row">
+          {{ ps.label_with_help(('Display out-of-stock products last'|trans), ('If enabled, products will be displayed in this order: 1. in-stock, 2. available for order but quantity is 0, 3. out-of-stock. Note that it apply only when ordering by quantity, price or dates'|trans({}, 'Admin.Shopparameters.Help'))) }}


I would not use the word 'reordering' here, it can be ambiguous. What about Note that it only applies when filtering by quantity, price or date. instead?

...sources/views/Admin/Configure/ShopParameters/Blocks/product_preferences_pagination.html.twig

…eters/Blocks/product_preferences_pagination.html.twig Co-Authored-By: LouiseBonnard <32565890+LouiseBonnard@users.noreply.github.com>

PierreRambaud · 2021-03-02T16:24:50Z

Hi @gadnis ,

Since we had no news from you for more than 30 days, I'll close this pull request. Feel free to reopen or open another one if you think it's still relevant.

Thanks!

gadnis and others added 7 commits July 16, 2018 16:12

Add stock quantity variable inside cart summary notification error

a36cd1a

When user adjust quantity in cart summary and wanted quantity is more than 'in-stock', than error notification shown, but with this improvement user knows maximum product quantity he can buy.

Update CartController.php

6fec6fa

BO: Product settings- field added. FO: Products is sorting in price-d…

4a39349

…rop, category pages, more to come

FO: sort inStock,OutOfStock & OOPS, OutOfStock.Pages:category,new-pro…

80cd1c3

…ducts,product-sales,prices-drop

removed unnecessary comment

b9086e1

changed ps.label_with_help for display_out_of_stock_last field

6ce49e1

removed row string

7724033

prestonBot added Feature Type: New Feature Waiting for wording Status: action required, waiting for wording labels Feb 5, 2019

matks added the Waiting for PM Status: action required, waiting for product feedback label Feb 6, 2019

prestonBot added the develop Branch label Feb 6, 2019

colinegin assigned MatShir Feb 12, 2019

MatShir added PM ✔️ Status: check done, behavior approved and removed Waiting for PM Status: action required, waiting for product feedback labels Apr 12, 2019

LouiseBonnard reviewed Apr 15, 2019

View reviewed changes

LouiseBonnard added the Waiting for author Status: action required, waiting for author feedback label Apr 15, 2019

marionf self-assigned this Aug 1, 2019

marionf added Waiting for PM Status: action required, waiting for product feedback and removed PM ✔️ Status: check done, behavior approved labels Aug 1, 2019

marionf removed the Waiting for PM Status: action required, waiting for product feedback label Sep 11, 2019

marionf mentioned this pull request Sep 11, 2019

FO: New Feature - Sort products: InStock,OOPS with qty 0, OutOfStock PrestaShop/ps_facetedsearch#51

Closed

Latest 1.7.6.2 compatible change

51c54b0

Adding switch to enable or disable the feature

gadnis requested a review from a team as a code owner December 4, 2019 16:49

PS 1.7.6.2 compatible change

ba44f93

Adding SwitchType to a Form. To be able switch off|on this feature

gadnis added 6 commits December 4, 2019 18:57

PS 1.7.6.2 compatible change

81e17a4

Adding configuration field 'display_out_of_stock_last'. It will be used to either enable or disable the feature

PS 1.7.6.2 compatible chage

1ff4f6a

This one is not related to the feature. I'm not sure why it is in this PR. But it is useful.

PS 1.7.6.2 compatible change

96c0d31

Adding two methods: orderByOOSP and sqlOrderByOOSP There is All "facets" where we allow to sort out-of-stock last in method sqlOrderByOOSP And method orderByOOSP helps to do that later

PS 1.7.6.2 compatible change

67281c9

PS 1.7.6.2 compatible change

b4a1570

changes marked with comment: ORDER BY out-of-stock products last

PS 1.7.6.2 compatible change

4e23a24

Allowing order products as described in PR Changes marked with comment: ORDER BY out-of-stock products last

gadnis commented Dec 4, 2019

View reviewed changes

Merge branch 'develop' into new-feature-display-out-of-stock-products…

4cd42d2

…-last

LouiseBonnard reviewed Dec 5, 2019

View reviewed changes

Note changed

e7105a9

LouiseBonnard reviewed Dec 5, 2019

View reviewed changes

...sources/views/Admin/Configure/ShopParameters/Blocks/product_preferences_pagination.html.twig Outdated Show resolved Hide resolved

Update src/PrestaShopBundle/Resources/views/Admin/Configure/ShopParam…

2d3cc46

…eters/Blocks/product_preferences_pagination.html.twig Co-Authored-By: LouiseBonnard <32565890+LouiseBonnard@users.noreply.github.com>

LouiseBonnard added Wording ✔️ Status: check done, wording approved and removed Waiting for wording Status: action required, waiting for wording labels Dec 5, 2019

PierreRambaud closed this Mar 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New optional feature - display out of stock products last #12441

New optional feature - display out of stock products last #12441

gadnis commented Feb 5, 2019 •

edited by PierreRambaud

prestonBot commented Feb 5, 2019

matks commented Feb 6, 2019

LouiseBonnard Apr 15, 2019

marionf commented Aug 1, 2019 •

edited

gadnis commented Aug 1, 2019

marionf commented Aug 2, 2019

gadnis commented Aug 2, 2019

gadnis left a comment

gadnis commented Dec 4, 2019

LouiseBonnard Dec 5, 2019

PierreRambaud commented Mar 2, 2021

New optional feature - display out of stock products last #12441

New optional feature - display out of stock products last #12441

Conversation

gadnis commented Feb 5, 2019 • edited by PierreRambaud

prestonBot commented Feb 5, 2019

matks commented Feb 6, 2019

LouiseBonnard Apr 15, 2019

Choose a reason for hiding this comment

marionf commented Aug 1, 2019 • edited

gadnis commented Aug 1, 2019

marionf commented Aug 2, 2019

gadnis commented Aug 2, 2019

gadnis left a comment

Choose a reason for hiding this comment

gadnis commented Dec 4, 2019

LouiseBonnard Dec 5, 2019

Choose a reason for hiding this comment

PierreRambaud commented Mar 2, 2021

gadnis commented Feb 5, 2019 •

edited by PierreRambaud

marionf commented Aug 1, 2019 •

edited