Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a descriptif comment for the broken test "create_product_with_combination" #12481

Merged
merged 1 commit into from Feb 7, 2019
Merged

Add a descriptif comment for the broken test "create_product_with_combination" #12481

merged 1 commit into from Feb 7, 2019

Conversation

YosraAk
Copy link
Contributor

@YosraAk YosraAk commented Feb 7, 2019 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Add a comment in the script to specify the related issue.
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? /

This change is Reviewable

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Feb 7, 2019
@YosraAk YosraAk changed the title Add a descriptif comment for the broken test Add a descriptif comment for the broken test "create_product_with_combination" Feb 7, 2019
@khouloudbelguith khouloudbelguith added the TE Category: Tests label Feb 7, 2019
mbadrani
mbadrani approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@mbadrani mbadrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@mbadrani mbadrani added this to the 1.7.6.0 milestone Feb 7, 2019
@mbadrani mbadrani merged commit 665007e into PrestaShop:develop Feb 7, 2019
@marionf
Copy link
Contributor

marionf commented Feb 7, 2019

Related issue founded by this test: #9826 and #9775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbadrani mbadrani mbadrani approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement TE Category: Tests
Projects
None yet
Milestone
1.7.6.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YosraAk @marionf @mbadrani @khouloudbelguith @prestonBot