Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove timeout from product image upload #12761

Merged
merged 1 commit into from Mar 1, 2019
Merged

Remove timeout from product image upload #12761

merged 1 commit into from Mar 1, 2019

Conversation

JohnMidity
Copy link
Contributor

@JohnMidity JohnMidity commented Mar 1, 2019 •
edited by eternoendless

Questions Answers
Branch? develop
Description? DropZone.js introduced a timeout of 30s for uploading of product images. This timeout is removed with this DropZone option setting "timeout: 0" and timeouts for image uploads are controlled with PHP ini settings.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #12285 .
How to test? set php.ini to allow really big uploads, upload a product image exceeding 30 seconds time

This change is Reviewable

@prestonBot
Copy link
Collaborator

Hello @JohnMidity!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Mar 1, 2019
@Quetzacoalt91 Quetzacoalt91 added the Waiting for QA Status: action required, waiting for test feedback label Mar 1, 2019
@Quetzacoalt91 Quetzacoalt91 merged commit 9eb1b92 into PrestaShop:develop Mar 1, 2019
@Quetzacoalt91
Copy link
Member

Thank you @JohnMidity

I clicked too quickly on the merge button, a QA review is still appreciated. :)

@marionf marionf self-assigned this Mar 1, 2019
@marionf marionf added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Mar 1, 2019
@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Mar 11, 2019
@eternoendless eternoendless changed the title BO: Remove timeout from product image upload Remove timeout from product image upload Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

Assignees

@marionf marionf

Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.6.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JohnMidity @prestonBot @Quetzacoalt91 @PierreRambaud @marionf