Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate CLDR service #12766

Merged
merged 1 commit into from Mar 4, 2019
Merged

Remove duplicate CLDR service #12766

merged 1 commit into from Mar 4, 2019

Conversation

matks
Copy link
Contributor

@matks matks commented Mar 1, 2019 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Remove duplicated CLDR service
Type? refacto
Category? CO
BC breaks? no, because both services have been added for 1.7.6 so removing one is not a BC
Deprecations? no
Fixed ticket? Fixes #12118
How to test? International > Localization > Currencies page (listing + add/edit) should work as before, no regressions.

This change is Reviewable

@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring labels Mar 1, 2019
@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Mar 2, 2019
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Mar 2, 2019
@ntiepresta ntiepresta assigned ntiepresta and unassigned ntiepresta Mar 2, 2019
@ntiepresta ntiepresta added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Mar 4, 2019
@PierreRambaud PierreRambaud merged commit ecc3c75 into PrestaShop:develop Mar 4, 2019
@PierreRambaud
Copy link
Contributor

Thanks @matks

@matks matks deleted the remove-duplicate-cldr-service branch March 4, 2019 14:21
@eternoendless eternoendless changed the title Remove duplicated CLDR service Remove duplicate CLDR service Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees
No one assigned
Labels
develop Branch QA ✔️ Status: check done, code approved Refactoring Type: Refactoring
Projects
None yet
Milestone
1.7.6.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matks @PierreRambaud @prestonBot @ntiepresta