Do not look for translations if no locale

[matks]

Questions	Answers
Branch?	develop
Description?	You can create new languages from the BO but they get created without a locale. This can create performance issues when the core looks for related translations. This avoids the performance issue.
Type?	bug fix
Category?	CO
BC breaks?	no
Deprecations?	no
Fixed ticket?
How to test?	Waiting for @jocel1 to explain it a bit 😉

---

This change is 

[PierreRambaud]

It's because we don't want to get all catalog if there is no locale set.
So $translator->getCatalogue($locale)->all() will be not executed and it'll improve performance a lot.

[jocel1]

@PierreRambaud @matks actually it's not the getCatalogue() which hurts, it's the Finder::create() just after, because the pattern name ->name('*.' . $locale . '.*'); becomes *..* if locale is empty, and it matches a lot of file and directories!
So how to test: manually create a language, try to display a landing page with the language, with open_base_dir on to disable the filesystem cache (the Finder::create() will hurt a lot in this case). You can do a blackfire profiling to see the impact.

[PierreRambaud]

Thanks @jocel1 for explanation 😉

[matks]

Thank you for review and comments !

[kpodemski]

Wow, that was a tricky one, i stumble upon this issue but couldn't find proper solution 👍