Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm install not working anymore on new-theme #13066

Merged
merged 2 commits into from Mar 27, 2019
Merged

Fix npm install not working anymore on new-theme #13066

merged 2 commits into from Mar 27, 2019

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented Mar 27, 2019 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Npm install is broken due to invalid dependencies tree.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? YOu should be able to do a npm install on admin-dev/themes/new-theme.

This change is Reviewable

@prestonBot prestonBot added develop Branch Bug Type: Bug Waiting for wording Status: action required, waiting for wording labels Mar 27, 2019
@PierreRambaud PierreRambaud removed the Waiting for wording Status: action required, waiting for wording label Mar 27, 2019
@marionf marionf added the QA ✔️ Status: check done, code approved label Mar 27, 2019
@marionf marionf mentioned this pull request Mar 27, 2019
Merged
@matks
Copy link
Contributor

matks commented Mar 27, 2019 •
edited

Image source: https://twitter.com/msdev/status/547859259455995904

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Mar 27, 2019
@matks matks changed the title Npm install not working anymore on new-theme Fix npm install not working anymore on new-theme Mar 27, 2019
@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Mar 27, 2019
@matks matks merged commit 044ccc9 into PrestaShop:develop Mar 27, 2019
@matks
Copy link
Contributor

matks commented Mar 27, 2019

Thank you @PierreRambaud

@matks matks removed the Waiting for wording Status: action required, waiting for wording label Mar 27, 2019
@PierreRambaud PierreRambaud deleted the fix/npm branch March 27, 2019 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.6.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PierreRambaud @matks @marionf @prestonBot