Tax page fixes

[zuk3975]

Questions	Answers
Branch?	develop
Description?	../PrestaShopBundle/Resources/config/routing/admin/improve/international/tax.yml was missing _legacy_parameters in admin_taxes_delete route. Added missing TypedRegexConstraint in TaxType
Type?	refacto
Category?	BO
BC breaks?	no
Deprecations?	no
Fixed ticket?
How to test?	Does not impact user interface

---

This change is 

[zuk3975]

@matks one more tiny PR. Didint find anything more to fix in taxes

[matks]

@zuk3975 It's a bit outside of the scope of this PR, but could you unit test class TypedRegexValidator 😃 ?

[mickaelandrieu]

It's a bit outside of the scope of this PR, but could you unit test class TypedRegexValidator ?

I had the same feeling 😆

[zuk3975]

@zuk3975 It's a bit outside of the scope of this PR, but could you unit test class TypedRegexValidator ?

@matks added some unit tests.
I tried to avoid using dataProviders(as i was suggested for performance) and do simple foreach instead, but I couldnt due to extended ConstraintValidatorTestCase which is keeping violations in context and is restricted to get exactly 1 violation (not sure why though) - tests teared apart once it reached at least 2 violations. So I couldn't find proper way to reset violations and stayed with dataProviders.

[matks]

@zuk3975 It's a bit outside of the scope of this PR, but could you unit test class TypedRegexValidator ?

@matks added some unit tests.
I tried to avoid using dataProviders(as i was suggested for performance) and do simple foreach instead, but I couldnt due to extended ConstraintValidatorTestCase which is keeping violations in context and is restricted to get exactly 1 violation (not sure why though) - tests teared apart once it reached at least 2 violations. So I couldn't find proper way to reset violations and stayed with dataProviders.

No worries 😄 great job

[matks]

It needs a rebase as TypedRegexConstraint is now TypedRegex

[zuk3975]

It needs a rebase as TypedRegexConstraint is now TypedRegex

@matks done :)

[matks]

It needs a rebase as TypedRegexConstraint is now TypedRegex

@matks done :)

😅 unfortunately there are still traces of TypedRegexConstraint according to Travis

> @php -d date.timezone=UTC ./vendor/bin/phpunit -c tests-legacy/phpunit-admin.xml
PHPUnit 5.7.27 by Sebastian Bergmann and contributors.
...............................................................  63 / 133 ( 47%)
.....................
Fatal error: Class 'PrestaShop\PrestaShop\Core\ConstraintValidator\Constraints\TypedRegexConstraint' not found in /home/travis/build/PrestaShop/PrestaShop/src/PrestaShopBundle/Form/Admin/Improve/International/Tax/TaxType.php on line 76

[zuk3975]

It needs a rebase as TypedRegexConstraint is now TypedRegex

@matks done :)

unfortunately there are still traces of TypedRegexConstraint according to Travis

> @php -d date.timezone=UTC ./vendor/bin/phpunit -c tests-legacy/phpunit-admin.xml
PHPUnit 5.7.27 by Sebastian Bergmann and contributors.
...............................................................  63 / 133 ( 47%)
.....................
Fatal error: Class 'PrestaShop\PrestaShop\Core\ConstraintValidator\Constraints\TypedRegexConstraint' not found in /home/travis/build/PrestaShop/PrestaShop/src/PrestaShopBundle/Form/Admin/Improve/International/Tax/TaxType.php on line 76

@matks Finally travis looks happy :D

[matks]

Thank you @zuk3975