Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notice undefined index: icon on Design -> Positions #13177

Merged
merged 1 commit into from Apr 4, 2019
Merged

Fix notice undefined index: icon on Design -> Positions #13177

merged 1 commit into from Apr 4, 2019

Conversation

Matt75
Copy link
Contributor

@Matt75 Matt75 commented Apr 4, 2019 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Fix a PHP Notice on Design -> Positions, in toolbar, button Transplant a module
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? https://www.prestashop.com/forums/topic/963504-php-notice-warning/
How to test? Check html code of button Transplant a module on Design -> Positions, before <i class="material-icons"></i> Transplant a module After Transplant a module

This change is Reviewable

@prestonBot prestonBot added develop Branch Bug Type: Bug labels Apr 4, 2019
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Apr 4, 2019
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Apr 4, 2019
@sarahdib sarahdib self-assigned this Apr 4, 2019
@matks matks added migration symfony migration project and removed migration symfony migration project labels Apr 4, 2019
@matks
Copy link
Contributor

matks commented Apr 4, 2019

Thank you @Matt75

@matks matks added this to the 1.7.6.0 milestone Apr 4, 2019
@matks matks merged commit f7ae842 into PrestaShop:develop Apr 4, 2019
@Matt75 Matt75 deleted the fix-notice-bo-toolbar branch September 24, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees

@sarahdib sarahdib

Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.6.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Matt75 @matks @PierreRambaud @sarahdib @prestonBot