Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breadcrumb in search results page leads to 404 page #13218

Merged
merged 1 commit into from Apr 8, 2019
Merged

Fix breadcrumb in search results page leads to 404 page #13218

merged 1 commit into from Apr 8, 2019

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented Apr 5, 2019 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Use the current url instead of generating a new search url with no search string.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #12401
How to test? Follow ticket instruction

This change is Reviewable

@prestonBot prestonBot added develop Branch Bug Type: Bug labels Apr 5, 2019
@matks matks modified the milestones: 1.7.7.0, 1.7.6.0 Apr 8, 2019
@matks matks added the Waiting for QA Status: action required, waiting for test feedback label Apr 8, 2019
@marionf marionf self-assigned this Apr 8, 2019
@marionf marionf added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Apr 8, 2019
@Quetzacoalt91 Quetzacoalt91 merged commit 472cb85 into PrestaShop:develop Apr 8, 2019
@eternoendless eternoendless changed the title Breadcrumb in search results page brings to 404 page Fix breadcrumb in search results page leads to 404 page Apr 12, 2019
@PierreRambaud PierreRambaud deleted the fix/12401 branch February 14, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

Assignees

@marionf marionf

Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.6.0
Development

Successfully merging this pull request may close these issues.

Breadcrumb in search results page brings to 404 page
5 participants
@PierreRambaud @matks @Quetzacoalt91 @marionf @prestonBot