Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing showcase card in CMS page #13404

Merged
merged 7 commits into from Apr 16, 2019
Merged

Add missing showcase card in CMS page #13404

merged 7 commits into from Apr 16, 2019

Conversation

tomas862
Copy link
Contributor

Questions Answers
Branch? 1.7.6.x
Description? Adds helper card in cms page located in /admin-dev/index.php/improve/design/cms-pages
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Check the page how it looks like - also when everything looks okey, try to click on 'x' to remove that block. Before the testing make sure assets are up to date by running npm run build

NOTE

This PR is derived from #13163

This change is Reviewable

@prestonBot prestonBot added 1.7.6.x Branch Improvement Type: Improvement Waiting for wording Status: action required, waiting for wording labels Apr 15, 2019
@tomas862 tomas862 changed the title [WIP] missing showcase card in cms page implementation missing showcase card in cms page implementation Apr 15, 2019
@tomas862 tomas862 mentioned this pull request Apr 15, 2019
Closed
@matks
Copy link
Contributor

matks commented Apr 15, 2019 •
edited

To be merged after #13234 in order to avoid conflicts

@LouiseBonnard LouiseBonnard added Wording ✔️ Status: check done, wording approved and removed Waiting for wording Status: action required, waiting for wording labels Apr 16, 2019
@matks
Copy link
Contributor

matks commented Apr 16, 2019

@tomas862 #13234 is merged 👍

@matks matks mentioned this pull request Apr 16, 2019
Closed
7 tasks
@tomas862 tomas862 force-pushed the bugfix/missing-showcase-card-in-cms-page-implementation branch from 6c33af6 to ca9b1cc Compare April 16, 2019 09:47
@tomas862
Copy link
Contributor Author

@matks rebased 👍

@matks matks added the Waiting for QA Status: action required, waiting for test feedback label Apr 16, 2019
@matks matks added this to the 1.7.6.0 milestone Apr 16, 2019
@matks matks added the migration symfony migration project label Apr 16, 2019
@sarahdib sarahdib self-assigned this Apr 16, 2019
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Apr 16, 2019
@Quetzacoalt91 Quetzacoalt91 merged commit 0f70c52 into PrestaShop:1.7.6.x Apr 16, 2019
@Quetzacoalt91
Copy link
Member

Thank you @tomas862

@eternoendless eternoendless changed the title missing showcase card in cms page implementation Add missing showcase card in CMS page May 10, 2019
@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label May 10, 2019
@jolelievre jolelievre removed the Waiting for wording Status: action required, waiting for wording label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouiseBonnard LouiseBonnard LouiseBonnard left review comments

@matks matks matks approved these changes

Assignees

@sarahdib sarahdib

Labels
1.7.6.x Branch Improvement Type: Improvement migration symfony migration project QA ✔️ Status: check done, code approved Wording ✔️ Status: check done, wording approved
Projects
None yet
Milestone
1.7.6.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tomas862 @matks @Quetzacoalt91 @LouiseBonnard @sarahdib @jolelievre @prestonBot