Fix currency display on not existing language #13525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matks
reviewed
Apr 23, 2019
| * If null, default language will be used | ||
| * @param int|false|null $idLang | ||
| * Set this parameter if you want the currency in a specific language. | ||
| * If null, default language will be used |
There was a problem hiding this comment.
Suggested change
| * If null, default language will be used | |
| * If null or false, default language will be used |
Does it make sense ?
matks
reviewed
Apr 23, 2019
| @@ -179,7 +179,7 @@ public function __construct($id = null, $idLang = null, $idShop = null) | |||
| if ($this->iso_code) { | |||
| // As the CLDR used to return a string even if in multi shop / lang, | |||
| // We force only one string to be returned | |||
| if (null === $idLang) { | |||
| if (empty($idLang)) { | |||
There was a problem hiding this comment.
Is it possible to improve this constructor phpdoc ?
matks
approved these changes
Apr 24, 2019
matks
added
the
Waiting for QA
marionf
added
QA ✔️
eternoendless
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is