Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure index exist before getting value for gift message #13923

Merged
merged 1 commit into from Jun 10, 2019
Merged

Make sure index exist before getting value for gift message #13923

merged 1 commit into from Jun 10, 2019

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented May 22, 2019 •
edited by eternoendless

Questions Answers
Branch? 1.7.6.x
Description? the index check was not the good one :trollface:
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #13478
How to test? Follow ticket instruction.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from a team as a code owner May 22, 2019 14:24
@prestonBot prestonBot added 1.7.6.x Branch Bug Type: Bug labels May 22, 2019
@PierreRambaud PierreRambaud modified the milestones: 1.7.7.0, 1.7.6.0 Jun 6, 2019
@Quetzacoalt91 Quetzacoalt91 added the Waiting for QA Status: action required, waiting for test feedback label Jun 7, 2019
jolelievre
jolelievre approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @PierreRambaud

@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 10, 2019
@PierreRambaud PierreRambaud merged commit 62c18ad into PrestaShop:1.7.6.x Jun 10, 2019
@PierreRambaud PierreRambaud deleted the fix/13478 branch February 14, 2020 09:18
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

@jolelievre jolelievre jolelievre approved these changes

Assignees
No one assigned
Labels
1.7.6.x Branch Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.6.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PierreRambaud @Quetzacoalt91 @jolelievre @sarahdib @prestonBot