Add comment in Customer registration form, add better error message #14138

jolelievre · 2019-06-10T12:14:26Z

Questions	Answers
Branch?	1.7.6.x
Description?	Add comment in Customer registration form, add better error message
Type?	improvement
Category?	FO
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #13640
How to test?	Try to register a new customer, you should see comments under Firstname and Lastname fields If trying to send an invalid value `John R.Hamond` a more detailed error message is displayed

This change is

classes/ValidateConstraintTranslator.php

classes/form/CustomerFormatter.php

classes/ValidateConstraintTranslator.php

PierreRambaud · 2019-06-10T13:27:54Z

themes/classic/templates/_partials/form-errors.tpl

@@ -27,7 +27,7 @@
    {block name='form_errors'}
      <ul>
        {foreach $errors as $error}
-          <li class="alert alert-danger">{$error}</li>
+          <li class="alert alert-danger">{$error|strip_tags|nl2br nofilter}</li>


why strip_tags?

to be sure no html tag is inserted (since I use nofilter) only the converted \n remain

I can remove it, it will still work but I was worried of XSS injection 😛

only if someone include xss in translations, but we should be worried if it happens ^^

alright I'll remove it then

jolelievre · 2019-06-11T07:41:07Z

themes/classic/templates/_partials/form-fields.tpl

@@ -170,7 +170,7 @@
          >
          {if isset($field.availableValues.comment)}
            <span class="form-control-comment">
-              {$field.availableValues.comment}
+              {$field.availableValues.comment|nl2br nofilter}


@PierreRambaud I also removed this strip_tag

PierreRambaud

I don't like the concat but not other way from now 😭

jolelievre · 2019-06-11T10:24:30Z

I don't like the concat but not other way from now 😭

Me neither, but if I return an array the error blocks are separated.. This would require to change too many templates and error management..

LouiseBonnard · 2019-06-11T10:26:52Z

classes/ValidateConstraintTranslator.php

+                'Shop.Forms.Errors'
+            ) . PHP_EOL .
+            $this->translator->trans(
+                'The following characters are not accepted: / \ ^ * `',


I think we should tend towards shorter wordings, otherwise error notifications will be too present and discouraging. What about Invalid characters: /^*` instead?

Seems good to me, @Samuel-Pires wdyt?

LouiseBonnard · 2019-06-11T10:31:47Z

classes/ValidateConstraintTranslator.php

+                'Shop.Forms.Errors'
+            ) . PHP_EOL .
+            $this->translator->trans(
+                'The characters . and 。 are allowed only if they are directly followed by a space or the end of the string.',


I wonder about the "。" character... it seems pretty specific, is it an absolute necessity to mention it?

Well this character is indeed forbidden, but maybe you're right If someone tries to use this character it is probably in order to use the breach so maybe it's not useful to indicate it for usual users

marionf · 2019-06-11T15:17:49Z

@jolelievre some returns, seen with @Samuel-Pires and @TristanLDD

Delete the message under the fields

There are some other prohibited characters that are not accepted and not displayed in the message like: 0-9!<>,;?=+()@#"°{}_$%: we should add them
Replace "The following characters are not accepted: " by "Invalid characters: "
Replace "The characters . and 。 are allowed only if they are directly followed by a space or the end of the string." by "A space is needed after "." and "。""

LouiseBonnard · 2019-06-11T15:27:09Z

@marionf, about the wording, you can also write A space is required after "." and "。" to give a sense of obligation.

jolelievre · 2019-06-11T16:47:01Z

@marionf @LouiseBonnard @Samuel-Pires @TristanLDD
All your modifications have been addressed, this should be good unless you find other issues?

LouiseBonnard · 2019-06-11T16:51:46Z

classes/ValidateConstraintTranslator.php

+                'Shop.Forms.Errors'
+            ) . PHP_EOL .
+            $this->translator->trans(
+                'A space is required after . and 。',


Shouldn't it be written with quotation marks? Example: A space is required after "." and "。"

I don't know what is the best practice.

Tristan was for the ""

So you mean using 'A space is required after "." and "。"'
(Isn't the space after 。 weird in this case?)

NB: the space can't be removed, it's part of the character

Great, then @PierreRambaud can you re-approve this PR please? ^^

I think maybe some email browsers simplify them and convert them into regular . thus creating a clickable url

I confirm, try visiting https://www.apple。com 😄

But... this PR has been merged without the fix on the wording?

Great, then @PierreRambaud can you re-approve this PR please? ^^

@LouiseBonnard we've been tricked !

Oups my bad, I was too quick and thought I had already added it
Here's a PR to fix this ^^
#14163

jolelievre added this to the 1.7.6.0 milestone Jun 10, 2019

jolelievre requested a review from a team as a code owner June 10, 2019 12:14

prestonBot added 1.7.6.x Branch Improvement Type: Improvement Waiting for wording Status: action required, waiting for wording Needs port on StarterTheme labels Jun 10, 2019

PierreRambaud reviewed Jun 10, 2019

View reviewed changes

classes/ValidateConstraintTranslator.php Outdated Show resolved Hide resolved

PierreRambaud removed the Needs port on StarterTheme label Jun 10, 2019

PierreRambaud reviewed Jun 10, 2019

View reviewed changes

classes/form/CustomerFormatter.php Outdated Show resolved Hide resolved

PierreRambaud reviewed Jun 10, 2019

View reviewed changes

classes/ValidateConstraintTranslator.php Outdated Show resolved Hide resolved

PierreRambaud reviewed Jun 10, 2019

View reviewed changes

jolelievre force-pushed the customer-name-infos branch from 84fac05 to 5000116 Compare June 10, 2019 14:42

jolelievre commented Jun 11, 2019

View reviewed changes

PierreRambaud previously approved these changes Jun 11, 2019

View reviewed changes

PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Jun 11, 2019

LouiseBonnard reviewed Jun 11, 2019

View reviewed changes

marionf added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 11, 2019

jolelievre dismissed PierreRambaud’s stale review via 2844873 June 11, 2019 16:44

Add better error messages for customer firstname and name

3c81050

jolelievre force-pushed the customer-name-infos branch from 2844873 to 3c81050 Compare June 11, 2019 16:45

LouiseBonnard reviewed Jun 11, 2019

View reviewed changes

LouiseBonnard added Wording ✔️ Status: check done, wording approved and removed Waiting for wording Status: action required, waiting for wording labels Jun 11, 2019

marionf removed the Waiting for author Status: action required, waiting for author feedback label Jun 12, 2019

matks approved these changes Jun 12, 2019

View reviewed changes

marionf added the QA ✔️ Status: check done, code approved label Jun 12, 2019

Quetzacoalt91 merged commit 110e7da into PrestaShop:1.7.6.x Jun 12, 2019

jolelievre mentioned this pull request Jun 12, 2019

Add missing quotes in error message #14163

Merged

jolelievre deleted the customer-name-infos branch July 12, 2019 00:06

ghost added the Front-end Category: Front end label Jul 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add comment in Customer registration form, add better error message #14138

Add comment in Customer registration form, add better error message #14138

jolelievre commented Jun 10, 2019 •

edited by eternoendless

PierreRambaud Jun 10, 2019

jolelievre Jun 10, 2019

jolelievre Jun 10, 2019

PierreRambaud Jun 10, 2019

jolelievre Jun 11, 2019

jolelievre Jun 11, 2019

jolelievre Jun 11, 2019

PierreRambaud left a comment

jolelievre commented Jun 11, 2019

LouiseBonnard Jun 11, 2019

jolelievre Jun 11, 2019

LouiseBonnard Jun 11, 2019

jolelievre Jun 11, 2019

marionf commented Jun 11, 2019 •

edited

LouiseBonnard commented Jun 11, 2019

jolelievre commented Jun 11, 2019

LouiseBonnard Jun 11, 2019

LouiseBonnard Jun 11, 2019

ghost Jun 11, 2019

jolelievre Jun 11, 2019

jolelievre Jun 11, 2019

jolelievre Jun 12, 2019

matks Jun 12, 2019 •

edited

LouiseBonnard Jun 12, 2019

matks Jun 12, 2019

jolelievre Jun 12, 2019

Add comment in Customer registration form, add better error message #14138

Add comment in Customer registration form, add better error message #14138

Conversation

jolelievre commented Jun 10, 2019 • edited by eternoendless

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PierreRambaud left a comment

Choose a reason for hiding this comment

jolelievre commented Jun 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marionf commented Jun 11, 2019 • edited

LouiseBonnard commented Jun 11, 2019

jolelievre commented Jun 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matks Jun 12, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jolelievre commented Jun 10, 2019 •

edited by eternoendless

marionf commented Jun 11, 2019 •

edited

matks Jun 12, 2019 •

edited